You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Koushik Das <ko...@citrix.com> on 2013/12/03 09:44:22 UTC
Re: Review Request 15763: Changed 'MigrateCommand' to use the global setting
value of 'execute.in.sequence.hypervisor.commands'
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15763/#review29649
-----------------------------------------------------------
core/src/com/cloud/agent/api/MigrateCommand.java
<https://reviews.apache.org/r/15763/#comment57065>
I see that you have tested for XS. In the mail thread people have mentioned that it should work on Vmware and KVM. Will it be possible to do a quick verification?
Otherwise (except for a few minor comments) the change looks good to me.
setup/db/db/schema-410to420.sql
<https://reviews.apache.org/r/15763/#comment57063>
Since the change is for master, this is not required. 430-440 upgrade should suffice.
setup/db/db/schema-430to440.sql
<https://reviews.apache.org/r/15763/#comment57064>
Also the description needs to be updated in VirtualMachineManager.java where ExecuteInSequence is defined.
- Koushik Das
On Nov. 21, 2013, 6:39 p.m., Alex Ough wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15763/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2013, 6:39 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> When a host is switched to the 'maintenance mode', the vms in that host are migrated to another available hosts. Currently, the vm migrations are executed sequentially, it can take a lot of time when there are quite number of vms. So I changed 'MigrateCommand' to get the value of 'executeInSequence' property from the global setting value of 'execute.in.sequence.hypervisor.commands' so that users can execute the migrations in parallel to save time.
>
>
> Diffs
> -----
>
> core/src/com/cloud/agent/api/MigrateCommand.java 0d8f70c
> engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 3a3de70
> setup/db/db/schema-410to420.sql 522ccc4
> setup/db/db/schema-430to440.sql 9bb9602
>
> Diff: https://reviews.apache.org/r/15763/diff/
>
>
> Testing
> -------
>
> Tested in the simulator mode and Xen servers.
>
>
> Thanks,
>
> Alex Ough
>
>
Re: Review Request 15763: Changed 'MigrateCommand' to use the global setting
value of 'execute.in.sequence.hypervisor.commands'
Posted by Koushik Das <ko...@citrix.com>.
> On Dec. 3, 2013, 8:44 a.m., Koushik Das wrote:
> > core/src/com/cloud/agent/api/MigrateCommand.java, line 32
> > <https://reviews.apache.org/r/15763/diff/1/?file=389559#file389559line32>
> >
> > I see that you have tested for XS. In the mail thread people have mentioned that it should work on Vmware and KVM. Will it be possible to do a quick verification?
> >
> > Otherwise (except for a few minor comments) the change looks good to me.
Now that HyperV is also there can there be any issues with that?
- Koushik
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15763/#review29649
-----------------------------------------------------------
On Nov. 21, 2013, 6:39 p.m., Alex Ough wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15763/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2013, 6:39 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> When a host is switched to the 'maintenance mode', the vms in that host are migrated to another available hosts. Currently, the vm migrations are executed sequentially, it can take a lot of time when there are quite number of vms. So I changed 'MigrateCommand' to get the value of 'executeInSequence' property from the global setting value of 'execute.in.sequence.hypervisor.commands' so that users can execute the migrations in parallel to save time.
>
>
> Diffs
> -----
>
> core/src/com/cloud/agent/api/MigrateCommand.java 0d8f70c
> engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 3a3de70
> setup/db/db/schema-410to420.sql 522ccc4
> setup/db/db/schema-430to440.sql 9bb9602
>
> Diff: https://reviews.apache.org/r/15763/diff/
>
>
> Testing
> -------
>
> Tested in the simulator mode and Xen servers.
>
>
> Thanks,
>
> Alex Ough
>
>