[jira] [Commented] (MESOS-4981) Framework (re-)register metric counters broken for calls made via scheduler driver

["Fan Du (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-4981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15203887#comment-15203887 ] 

Fan Du commented on MESOS-4981:
-------------------------------

[~anandmazumdar] I happened to look a deep look at this, here is fix works on my env.
Please review:
https://reviews.apache.org/r/45094/ 

> Framework (re-)register metric counters broken for calls made via scheduler driver
> ----------------------------------------------------------------------------------
>
>                 Key: MESOS-4981
>                 URL: https://issues.apache.org/jira/browse/MESOS-4981
>             Project: Mesos
>          Issue Type: Bug
>          Components: master
>            Reporter: Anand Mazumdar
>            Assignee: Fan Du
>              Labels: mesosphere
>
> The counters {{master/messages_register_framework}} and {{master/messages_reregister_framework}} are no longer being incremented after the scheduler driver started sending {{Call}} messages to the master in Mesos 0.23. Either, we should think about adding new counter(s) for {{Subscribe}} calls to the master for both PID/HTTP frameworks or modify the existing code to correctly increment the counters.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)