[jira] [Comment Edited] (PHOENIX-1171) Dropping the index is not verifying the associated table

["James Taylor (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14097890#comment-14097890 ] 

James Taylor edited comment on PHOENIX-1171 at 8/14/14 11:19 PM:
-----------------------------------------------------------------

Attaching additional patch that is more strict about the check:
- makes sure that both the schema name and table name match when we determine the parentTableName to use in our future checks.
- makes sure that the parentTableName matches the actual parentTable. Thus in the case where we pass in null, yet the table has a parentTable, we'll fail.

This covers the matching schemaName case, plus is more strict in general. Thanks for the review, [~jeffreyz].


was (Author: jamestaylor):
Attaching additional patch that is more strict about the check:
- makes sure that both the schema name and table name match when we determine the parentTableName to use in our future checks.
- makes sure that the parentTableName matches the actual parentTable. Thus in the case where we pass in null, yet the table has a parentTable, we'll fail.
This covers the matching schemaName case, plus is more strict in general.

> Dropping the index is not verifying the associated table
> --------------------------------------------------------
>
>                 Key: PHOENIX-1171
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1171
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.0.0
>         Environment: Linux HDP-2.1
>            Reporter: yeshwanth
>            Assignee: James Taylor
>              Labels: newbie, patch
>         Attachments: PHOENIX-1171-addendum.patch, PHOENIX-1171.patch
>
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> i had two tables,
> i created index on one table and dropped index by specifying other table,
> index was dropped succesfully, later when i tried indexing on the same table,
>  it had thrown me error saying the index table name already exists,
> looks like, the reference was not updated in phoenix table,
> 0: jdbc:phoenix:localhost:/hbase-unsecure> create table t1( id integer not null primary key ,name char(5));
> No rows affected (17.666 seconds)
> 0: jdbc:phoenix:localhost:/hbase-unsecure> create table t2( id integer not null primary key ,name char(5));
> No rows affected (1.296 seconds)
> 0: jdbc:phoenix:localhost:/hbase-unsecure> CREATE INDEX i1 ON t1  (id);
> No rows affected (3.164 seconds)
> 0: jdbc:phoenix:localhost:/hbase-unsecure> DROP INDEX i1 on t2;
> No rows affected (2.023 seconds)



--
This message was sent by Atlassian JIRA
(v6.2#6252)