You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/03/11 12:31:08 UTC

[GitHub] [mynewt-nimble] Reynevan94 opened a new pull request #768: Added advertiser, scanner, peripheral and central to apps

Reynevan94 opened a new pull request #768: Added advertiser, scanner, peripheral and central to apps
URL: https://github.com/apache/mynewt-nimble/pull/768
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] utzig commented on a change in pull request #768: Added advertiser, scanner, peripheral and central to apps

Posted by GitBox <gi...@apache.org>.

utzig commented on a change in pull request #768: Added advertiser, scanner, peripheral and central to apps
URL: https://github.com/apache/mynewt-nimble/pull/768#discussion_r390940536

##########
File path: apps/advertiser/pkg.yml
##########
@@ -0,0 +1,37 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+pkg.name: "apps/advertiser"
+pkg.type: app
+pkg.description: "Description of your app"
+pkg.author: "You <yo...@you.org>"

Review comment:
I like your email? :-)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [mynewt-nimble] utzig commented on a change in pull request #768: Added advertiser, scanner, peripheral and central to apps

Posted by GitBox <gi...@apache.org>.

utzig commented on a change in pull request #768: Added advertiser, scanner, peripheral and central to apps
URL: https://github.com/apache/mynewt-nimble/pull/768#discussion_r390940536

Review comment:
I like your email! :-)

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [mynewt-nimble] Reynevan94 commented on a change in pull request #768: Added advertiser, scanner, peripheral and central to apps

Posted by GitBox <gi...@apache.org>.

Reynevan94 commented on a change in pull request #768: Added advertiser, scanner, peripheral and central to apps
URL: https://github.com/apache/mynewt-nimble/pull/768#discussion_r390972337
 
 

 ##########
 File path: apps/advertiser/pkg.yml
 ##########
 @@ -0,0 +1,37 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#  http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+pkg.name: "apps/advertiser"
+pkg.type: app
+pkg.description: "Description of your app"
+pkg.author: "You <yo...@you.org>"
 
 Review comment:
   Fixed :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] Reynevan94 closed pull request #768: Added advertiser, scanner, peripheral and central to apps

Posted by GitBox <gi...@apache.org>.

Reynevan94 closed pull request #768: Added advertiser, scanner, peripheral and central to apps
URL: https://github.com/apache/mynewt-nimble/pull/768
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] rymanluk commented on issue #768: Added advertiser, scanner, peripheral and central to apps

Posted by GitBox <gi...@apache.org>.

rymanluk commented on issue #768: Added advertiser, scanner, peripheral and central to apps
URL: https://github.com/apache/mynewt-nimble/pull/768#issuecomment-597936059
 
 
   @utzig adding style checker here would be great :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] utzig commented on issue #768: Added advertiser, scanner, peripheral and central to apps

Posted by GitBox <gi...@apache.org>.

utzig commented on issue #768: Added advertiser, scanner, peripheral and central to apps
URL: https://github.com/apache/mynewt-nimble/pull/768#issuecomment-597640555
 
 
   I don't usually review nimble PRs, but since this was opened in mynewt-core before I was a bit curious. So there are some things like functions with `name(void)` vs `name()` (with no type), `case` not aligned below the `switch`, etc. I don't have strong preferences on style but I like consistency. @sjanc @andrzej-kaczmarek @rymanluk Is nimble following the same style that core uses? In that case maybe it would be interesting to add the style checker here as well!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services