You are viewing a plain text version of this content. The canonical link for it is here.
Posted to apreq-dev@httpd.apache.org by Stas Bekman <st...@stason.org> on 2004/06/16 20:16:56 UTC

Re: [mp2] APR w/o mod_perl

Joe Schaefer wrote:
> Stas Bekman <st...@stason.org> writes:
> 
> [...]
> 
> 
>>>>The rest is hard to tell as it's a big patch. Hopefully
>>>>nothing was missed. So go ahead and apply it and we will
>>>>take it from there. As I originally mentioned there were a
>>>>few minor issues with my original patch, but they may
>>>>remove themselves as you adjust it to work with win32.
> 
> 
> A data point:
> 
> The cgi.t test in httpd-apreq-2/glue/perl/t/apreq can be made to pass
> all its tests now.  However there were two things I needed to do to
> make that happen:
> 
>   1)  Add a LIBS=> "$aprutil_libs $apr_libs" argument to the
>       ModPerl::BuildMM::WriteMakefile call in lib/ModPerl/WrapXS.pm,
>       similar to the line in httpd-apreq2/build/xsbuilder.pl.

Perhaps we need to add a special wrapper to add these flags.

Why are you using BuildMM and not MM for libapreq? BuildMM is for mod_perl 
only or do you mean something else?

>   2) Expose APR::General::initialize in xs/maps/apr_functions.map
>      and call it at the top of the (generated) test_cgi.pl script.

That shouldn't be the case if you 'use APR', which does that thing already. I 
was thinking to have all APR:: modules load APR.pm internally.


-- 
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

Re: [mp2] APR w/o mod_perl

Posted by Joe Schaefer <jo...@sunstarsys.com>.
Stas Bekman <st...@stason.org> writes:

[...]

> Could you possibly contribute a test for modperl-2.0/t/apr-ext/, that you get
> that segfault with? Once we have it then it's easier to see why this doesn't
> work.

Errgh, I think this may just be user-error somewhere.  Today I retested &
reinstalled mp2's cvs-current; then rebuilt httpd-apreq-2, and apreq's
glue/perl/t/apreq/cgi.t test passed!  At this point I'm assuming that I 
screwed something up yesterday (maybe forgot to reinstall mp2 or do a
clean rebuild of httpd-apreq-2 after Randy's commit).

-- 
Joe Schaefer


Re: [mp2] APR w/o mod_perl

Posted by Stas Bekman <st...@stason.org>.
Joe Schaefer wrote:
> Stas Bekman <st...@stason.org> writes:
> 
> [...]
> 
> 
>>Why are you using BuildMM and not MM for libapreq? BuildMM is for
>>mod_perl only or do you mean something else?
> 
> 
> It's the .so's (like APR/Pool/Pool.so) in mp2 that need to be linked to 
> libapr.  apreq's .so's are already linked correctly.

Ah, OK, so it's mp2's APR-stand-alone issue. I suppose Randy handles that at 
the moment.

>>>  2) Expose APR::General::initialize in xs/maps/apr_functions.map
>>>     and call it at the top of the (generated) test_cgi.pl script.
>>
>>That shouldn't be the case if you 'use APR', which does that thing already. I
>>was thinking to have all APR:: modules load APR.pm internally.
>  
> That's what I was expecting to happen, but Randy's cgi.t test was
> segfaulting for me in apr_pool_create without this change.

Could you possibly contribute a test for modperl-2.0/t/apr-ext/, that you get 
that segfault with? Once we have it then it's easier to see why this doesn't work.

-- 
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

Re: [mp2] APR w/o mod_perl

Posted by Joe Schaefer <jo...@sunstarsys.com>.
Stas Bekman <st...@stason.org> writes:

[...]

> Why are you using BuildMM and not MM for libapreq? BuildMM is for
> mod_perl only or do you mean something else?

It's the .so's (like APR/Pool/Pool.so) in mp2 that need to be linked to 
libapr.  apreq's .so's are already linked correctly.

> 
> >   2) Expose APR::General::initialize in xs/maps/apr_functions.map
> >      and call it at the top of the (generated) test_cgi.pl script.
> 
> That shouldn't be the case if you 'use APR', which does that thing already. I
> was thinking to have all APR:: modules load APR.pm internally.

That's what I was expecting to happen, but Randy's cgi.t test was
segfaulting for me in apr_pool_create without this change.

-- 
Joe Schaefer


Re: [mp2] APR w/o mod_perl

Posted by Joe Schaefer <jo...@sunstarsys.com>.
Stas Bekman <st...@stason.org> writes:

[...]

> Why are you using BuildMM and not MM for libapreq? BuildMM is for
> mod_perl only or do you mean something else?

It's the .so's (like APR/Pool/Pool.so) in mp2 that need to be linked to 
libapr.  apreq's .so's are already linked correctly.

> 
> >   2) Expose APR::General::initialize in xs/maps/apr_functions.map
> >      and call it at the top of the (generated) test_cgi.pl script.
> 
> That shouldn't be the case if you 'use APR', which does that thing already. I
> was thinking to have all APR:: modules load APR.pm internally.

That's what I was expecting to happen, but Randy's cgi.t test was
segfaulting for me in apr_pool_create without this change.

-- 
Joe Schaefer