You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nlpcraft.apache.org by Aaron Radzinski <ar...@datalingvo.com> on 2020/03/31 20:29:48 UTC
[VOTE] Release Apache NLPCraft 0.5.0
NLPCraft-ers,
Our first ASF release is ready and up for the vote:
1. ZIP tarball
<https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/apache-nlpcraft-incubating-0.5.0.zip>
(SHA256
<https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/apache-nlpcraft-incubating-0.5.0.zip.sha256>,
PGP
<https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/apache-nlpcraft-incubating-0.5.0.zip.sig>
)
2. GitHub v0.5.0 tag
<https://gitbox.apache.org/repos/asf?p=incubator-nlpcraft.git;a=tag;h=refs/tags/v0.5.0>
3. JIRA resolved issues <http:///>
The vote is formal, see voting guidelines here:
https://www.apache.org/foundation/voting.html
+1 - to accept Apache NLPCraft 0.5.0
0 - don't care either way
-1 - DO NOT accept Apache NLPCraft 0.5.0 (explain why)
See notes on how to verify release here:
https://www.apache.org/info/verification.html
The vote will be held for 72 hours and will end on April 3rd 2020 at
midnight MSK.
Thank you!
--
Aaron Radzinski
Re: [VOTE] Release Apache NLPCraft 0.5.0
Posted by Nikita Ivanov <ni...@gmail.com>.
NLPCraft-ers,
I believe we still need 2 more *binding* (i.e. PMC members) votes for the
0.5.0 release to be voted in (correct me if I'm wrong here for incubating
releases).
Thanks,
--
Nikita Ivanov
On Tue, Mar 31, 2020 at 2:06 PM Sergey Makov <sm...@apache.org> wrote:
> +1
>
> On Tue, Mar 31, 2020 at 11:58 PM Dmitriy Monakhov <
> dmonakhov@datalingvo.com>
> wrote:
>
> > +1
> >
> > On Tue, Mar 31, 2020 at 11:51 PM Sergey Kamov <sk...@gmail.com>
> > wrote:
> >
> > > +1
> > >
> > > 31.03.2020 23:29, Aaron Radzinski пишет:
> > > > NLPCraft-ers,
> > > > Our first ASF release is ready and up for the vote:
> > > > 1. ZIP tarball
> > > > <
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/apache-nlpcraft-incubating-0.5.0.zip
> > > >
> > > > (SHA256
> > > > <
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/apache-nlpcraft-incubating-0.5.0.zip.sha256
> > > >,
> > > > PGP
> > > > <
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/apache-nlpcraft-incubating-0.5.0.zip.sig
> > > >
> > > > )
> > > > 2. GitHub v0.5.0 tag
> > > > <
> > >
> >
> https://gitbox.apache.org/repos/asf?p=incubator-nlpcraft.git;a=tag;h=refs/tags/v0.5.0
> > > >
> > > > 3. JIRA resolved issues <http:///>
> > > >
> > > > The vote is formal, see voting guidelines here:
> > > > https://www.apache.org/foundation/voting.html
> > > > +1 - to accept Apache NLPCraft 0.5.0
> > > > 0 - don't care either way
> > > > -1 - DO NOT accept Apache NLPCraft 0.5.0 (explain why)
> > > >
> > > > See notes on how to verify release here:
> > > > https://www.apache.org/info/verification.html
> > > >
> > > > The vote will be held for 72 hours and will end on April 3rd 2020 at
> > > > midnight MSK.
> > > >
> > > > Thank you!
> > > > --
> > > > Aaron Radzinski
> > > >
> > >
> >
> >
> > --
> > D. Monakhov
> >
>
Re: [VOTE] Release Apache NLPCraft 0.5.0
Posted by Sergey Makov <sm...@apache.org>.
+1
On Tue, Mar 31, 2020 at 11:58 PM Dmitriy Monakhov <dm...@datalingvo.com>
wrote:
> +1
>
> On Tue, Mar 31, 2020 at 11:51 PM Sergey Kamov <sk...@gmail.com>
> wrote:
>
> > +1
> >
> > 31.03.2020 23:29, Aaron Radzinski пишет:
> > > NLPCraft-ers,
> > > Our first ASF release is ready and up for the vote:
> > > 1. ZIP tarball
> > > <
> >
> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/apache-nlpcraft-incubating-0.5.0.zip
> > >
> > > (SHA256
> > > <
> >
> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/apache-nlpcraft-incubating-0.5.0.zip.sha256
> > >,
> > > PGP
> > > <
> >
> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/apache-nlpcraft-incubating-0.5.0.zip.sig
> > >
> > > )
> > > 2. GitHub v0.5.0 tag
> > > <
> >
> https://gitbox.apache.org/repos/asf?p=incubator-nlpcraft.git;a=tag;h=refs/tags/v0.5.0
> > >
> > > 3. JIRA resolved issues <http:///>
> > >
> > > The vote is formal, see voting guidelines here:
> > > https://www.apache.org/foundation/voting.html
> > > +1 - to accept Apache NLPCraft 0.5.0
> > > 0 - don't care either way
> > > -1 - DO NOT accept Apache NLPCraft 0.5.0 (explain why)
> > >
> > > See notes on how to verify release here:
> > > https://www.apache.org/info/verification.html
> > >
> > > The vote will be held for 72 hours and will end on April 3rd 2020 at
> > > midnight MSK.
> > >
> > > Thank you!
> > > --
> > > Aaron Radzinski
> > >
> >
>
>
> --
> D. Monakhov
>
Re: [VOTE] Release Apache NLPCraft 0.5.0
Posted by Dmitriy Monakhov <dm...@datalingvo.com>.
+1
On Tue, Mar 31, 2020 at 11:51 PM Sergey Kamov <sk...@gmail.com> wrote:
> +1
>
> 31.03.2020 23:29, Aaron Radzinski пишет:
> > NLPCraft-ers,
> > Our first ASF release is ready and up for the vote:
> > 1. ZIP tarball
> > <
> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/apache-nlpcraft-incubating-0.5.0.zip
> >
> > (SHA256
> > <
> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/apache-nlpcraft-incubating-0.5.0.zip.sha256
> >,
> > PGP
> > <
> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/apache-nlpcraft-incubating-0.5.0.zip.sig
> >
> > )
> > 2. GitHub v0.5.0 tag
> > <
> https://gitbox.apache.org/repos/asf?p=incubator-nlpcraft.git;a=tag;h=refs/tags/v0.5.0
> >
> > 3. JIRA resolved issues <http:///>
> >
> > The vote is formal, see voting guidelines here:
> > https://www.apache.org/foundation/voting.html
> > +1 - to accept Apache NLPCraft 0.5.0
> > 0 - don't care either way
> > -1 - DO NOT accept Apache NLPCraft 0.5.0 (explain why)
> >
> > See notes on how to verify release here:
> > https://www.apache.org/info/verification.html
> >
> > The vote will be held for 72 hours and will end on April 3rd 2020 at
> > midnight MSK.
> >
> > Thank you!
> > --
> > Aaron Radzinski
> >
>
--
D. Monakhov
Re: [VOTE] Release Apache NLPCraft 0.5.0
Posted by Sergey Kamov <sk...@gmail.com>.
+1
31.03.2020 23:29, Aaron Radzinski пишет:
> NLPCraft-ers,
> Our first ASF release is ready and up for the vote:
> 1. ZIP tarball
> <https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/apache-nlpcraft-incubating-0.5.0.zip>
> (SHA256
> <https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/apache-nlpcraft-incubating-0.5.0.zip.sha256>,
> PGP
> <https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/apache-nlpcraft-incubating-0.5.0.zip.sig>
> )
> 2. GitHub v0.5.0 tag
> <https://gitbox.apache.org/repos/asf?p=incubator-nlpcraft.git;a=tag;h=refs/tags/v0.5.0>
> 3. JIRA resolved issues <http:///>
>
> The vote is formal, see voting guidelines here:
> https://www.apache.org/foundation/voting.html
> +1 - to accept Apache NLPCraft 0.5.0
> 0 - don't care either way
> -1 - DO NOT accept Apache NLPCraft 0.5.0 (explain why)
>
> See notes on how to verify release here:
> https://www.apache.org/info/verification.html
>
> The vote will be held for 72 hours and will end on April 3rd 2020 at
> midnight MSK.
>
> Thank you!
> --
> Aaron Radzinski
>
Re: [VOTE] Release Apache NLPCraft 0.5.0
Posted by Furkan KAMACI <fu...@gmail.com>.
Hi Aaron,
Thanks for preparing the release!
I have some comments for the first Apache release candidate.
1) You can create a mail structure to make easier for the people who
want to review the release candidate. It is not something that every
incubator projects does but you can follow this as a great example:
https://lists.apache.org/thread.html/r57f06c1eb74f37e4eafc3181384cb660184d2431fa9fa9fa499cebf4%40%3Cdev.druid.apache.org%3E
You
don't necessarily include everything i.e. how to verify signatures. since
you have shared https://www.apache.org/info/verification.html.
2) Would you share the folder location of the artifacts instead of
providing the URL of the zip file (you can check the example below)?
3) Seems that there is an nlpcraft folder inside an nlpcraft folder dist.
So, artifacts are listed at:
https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/ Seems
that one folder is unnecessary. You can check this:
https://dist.apache.org/repos/dist/dev/incubator/druid/
4) It could be nice to provide the instructions on how to compile and test
the project for who wants to check it.
It can be painful to release the first Apache release. However, things get
much easier when we handle this one.
All in all,
-1 from me.
I checked:
- Incubating in name OK
- DISCLAIMER exists (OK - Consider using DISCLAIMER-WIP)
- LICENSE Not OK (Could you write which libraries has ASF 2.0 license as
like https://github.com/apache/druid/blob/master/LICENSE)
- NOTICE is OK
- Checked PGP signatures (Did you provide a .asc file)?
- Checked Checksums (OK)
- Code compiles and tests successfully run (Not OK) Here is an example:
Apr-02 23:16:27 [ERROR] Failed to start probe.
org.apache.nlpcraft.common.NCException: Failed to instantiate model:
org.apache.nlpcraft.model.intent.dsl.NCDslTestModel
at
org.apache.nlpcraft.probe.mgrs.deploy.NCDeployManager$.org$apache$nlpcraft$probe$mgrs$deploy$NCDeployManager$$makeModel(NCDeployManager.scala:133)
~[classes/:?]
at
org.apache.nlpcraft.probe.mgrs.deploy.NCDeployManager$$anonfun$start$1$$anonfun$apply$3.apply(NCDeployManager.scala:211)
~[classes/:?]
at
org.apache.nlpcraft.probe.mgrs.deploy.NCDeployManager$$anonfun$start$1$$anonfun$apply$3.apply(NCDeployManager.scala:211)
~[classes/:?]
at
scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:234)
~[scala-library-2.11.12.jar:?]
at
scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:234)
~[scala-library-2.11.12.jar:?]
at scala.collection.Iterator$class.foreach(Iterator.scala:891)
~[scala-library-2.11.12.jar:?]
at scala.collection.AbstractIterator.foreach(Iterator.scala:1334)
~[scala-library-2.11.12.jar:?]
at scala.collection.IterableLike$class.foreach(IterableLike.scala:72)
~[scala-library-2.11.12.jar:?]
at scala.collection.AbstractIterable.foreach(Iterable.scala:54)
~[scala-library-2.11.12.jar:?]
at scala.collection.TraversableLike$class.map(TraversableLike.scala:234)
~[scala-library-2.11.12.jar:?]
at scala.collection.AbstractTraversable.map(Traversable.scala:104)
~[scala-library-2.11.12.jar:?]
at
org.apache.nlpcraft.probe.mgrs.deploy.NCDeployManager$$anonfun$start$1.apply(NCDeployManager.scala:211)
~[classes/:?]
at
org.apache.nlpcraft.probe.mgrs.deploy.NCDeployManager$$anonfun$start$1.apply(NCDeployManager.scala:197)
~[classes/:?]
at
org.apache.nlpcraft.common.opencensus.NCOpenCensusTrace$class.startScopedSpan(NCOpenCensusTrace.scala:192)
~[classes/:?]
at org.apache.nlpcraft.common.NCService.startScopedSpan(NCService.scala:30)
~[classes/:?]
at
org.apache.nlpcraft.probe.mgrs.deploy.NCDeployManager$.start(NCDeployManager.scala:197)
~[classes/:?]
at
org.apache.nlpcraft.probe.NCProbeBoot$$anonfun$org$apache$nlpcraft$probe$NCProbeBoot$$startManagers$1.apply(NCProbeBoot.scala:418)
~[classes/:?]
at
org.apache.nlpcraft.probe.NCProbeBoot$$anonfun$org$apache$nlpcraft$probe$NCProbeBoot$$startManagers$1.apply(NCProbeBoot.scala:400)
~[classes/:?]
at
org.apache.nlpcraft.common.opencensus.NCOpenCensusTrace$class.startScopedSpan(NCOpenCensusTrace.scala:192)
~[classes/:?]
at
org.apache.nlpcraft.probe.NCProbeBoot$.startScopedSpan(NCProbeBoot.scala:58)
~[classes/:?]
at
org.apache.nlpcraft.common.opencensus.NCOpenCensusTrace$class.startScopedSpan(NCOpenCensusTrace.scala:120)
~[classes/:?]
at
org.apache.nlpcraft.probe.NCProbeBoot$.startScopedSpan(NCProbeBoot.scala:58)
~[classes/:?]
at
org.apache.nlpcraft.probe.NCProbeBoot$.org$apache$nlpcraft$probe$NCProbeBoot$$startManagers(NCProbeBoot.scala:400)
~[classes/:?]
at
org.apache.nlpcraft.probe.NCProbeBoot$$anonfun$1.apply$mcV$sp(NCProbeBoot.scala:171)
~[classes/:?]
at
org.apache.nlpcraft.probe.NCProbeBoot$$anonfun$1.apply(NCProbeBoot.scala:171)
~[classes/:?]
at
org.apache.nlpcraft.probe.NCProbeBoot$$anonfun$1.apply(NCProbeBoot.scala:171)
~[classes/:?]
at
scala.util.control.Exception$Catch$$anonfun$either$1.apply(Exception.scala:125)
~[scala-library-2.11.12.jar:?]
at
scala.util.control.Exception$Catch$$anonfun$either$1.apply(Exception.scala:125)
~[scala-library-2.11.12.jar:?]
at scala.util.control.Exception$Catch.apply(Exception.scala:103)
~[scala-library-2.11.12.jar:?]
at scala.util.control.Exception$Catch.either(Exception.scala:125)
~[scala-library-2.11.12.jar:?]
at
org.apache.nlpcraft.probe.NCProbeBoot$.org$apache$nlpcraft$probe$NCProbeBoot$$start0(NCProbeBoot.scala:171)
[classes/:?]
at org.apache.nlpcraft.probe.NCProbeBoot$$anon$3.run(NCProbeBoot.scala:269)
[classes/:?]
Caused by: org.apache.nlpcraft.common.NCException: Model configuration file
path not found: org/apache/nlpcraft/model/intent/dsl/dsl_test_model.yaml
at
org.apache.nlpcraft.model.NCModelFileAdapter.mkProxy(NCModelFileAdapter.java:131)
~[classes/:?]
at
org.apache.nlpcraft.model.NCModelFileAdapter.<init>(NCModelFileAdapter.java:71)
~[classes/:?]
at
org.apache.nlpcraft.model.intent.dsl.NCDslTestModel.<init>(NCDslTestModel.scala:25)
~[test-classes/:?]
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
~[?:1.8.0_231]
at
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
~[?:1.8.0_231]
at
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
~[?:1.8.0_231]
at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
~[?:1.8.0_231]
at
org.apache.nlpcraft.model.factories.basic.NCBasicModelFactory.mkModel(NCBasicModelFactory.java:70)
~[classes/:?]
at
org.apache.nlpcraft.probe.mgrs.deploy.NCDeployManager$$anonfun$4.apply(NCDeployManager.scala:143)
~[classes/:?]
at
org.apache.nlpcraft.probe.mgrs.deploy.NCDeployManager$$anonfun$4.apply(NCDeployManager.scala:143)
~[classes/:?]
at
scala.util.control.Exception$Catch$$anonfun$either$1.apply(Exception.scala:125)
~[scala-library-2.11.12.jar:?]
at
scala.util.control.Exception$Catch$$anonfun$either$1.apply(Exception.scala:125)
~[scala-library-2.11.12.jar:?]
at scala.util.control.Exception$Catch.apply(Exception.scala:103)
~[scala-library-2.11.12.jar:?]
at scala.util.control.Exception$Catch.either(Exception.scala:125)
~[scala-library-2.11.12.jar:?]
at
org.apache.nlpcraft.probe.mgrs.deploy.NCDeployManager$.org$apache$nlpcraft$probe$mgrs$deploy$NCDeployManager$$makeModelFromSource(NCDeployManager.scala:143)
~[classes/:?]
at
org.apache.nlpcraft.probe.mgrs.deploy.NCDeployManager$.org$apache$nlpcraft$probe$mgrs$deploy$NCDeployManager$$makeModel(NCDeployManager.scala:127)
~[classes/:?]
... 31 more
Kind Regards,
Furkan KAMACI
On Thu, Apr 2, 2020 at 10:00 PM Sergey Kamov <sk...@gmail.com> wrote:
> -1
>
> Sorry for previous email
>
> 1) Test suite isn't passed
> All tests passed one by one, but not in suite. "mvn verify" detected 4
> errors.
>
> [ERROR] Failures:
> [ERROR] NCDslTest.test:58 expected: <true> but was: <false>
> [ERROR] Errors:
> [ERROR] NCEnricherLimitSpec.test:33->NCEnricherBaseSpec.runBatch:135 »
> TestFailed Fail...
> [ERROR]
> NCEnricherNestedModelSpec.test:31->NCEnricherBaseSpec.runBatch:135 »
> TestFailed
> [ERROR] NCEnricherRelationSpec.test:33->NCEnricherBaseSpec.runBatch:135
> » TestFailed F...
> [ERROR] NCEnricherSortSpec.test:33->NCEnricherBaseSpec.runBatch:135 »
> TestFailed Faile...
>
> 2) Unexpected zip file signature.
>
> >> gpg --verify apache-nlpcraft-incubating-0.5.0.zip.sig
> apache-nlpcraft-incubating-0.5.0.zip
>
> gpg: Signature made Tue Mar 31 09:38:06 2020 MSK
> gpg: using RSA key 8EF51E7DC4DF1D751B82C77D3C47CC3F3F4CB613
> gpg: Good signature from "DataLingvo <in...@datalingvo.com>" [unknown]
> gpg: WARNING: This key is not certified with a trusted signature!
> gpg: There is no indication that the signature belongs to the
> owner.
> Primary key fingerprint: 8EF5 1E7D C4DF 1D75 1B82 C77D 3C47 CC3F 3F4C B613
>
>
> .
>
> 31.03.2020 23:29, Aaron Radzinski пишет:
> > NLPCraft-ers,
> > Our first ASF release is ready and up for the vote:
> > 1. ZIP tarball
> > <
> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/apache-nlpcraft-incubating-0.5.0.zip
> >
> > (SHA256
> > <
> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/apache-nlpcraft-incubating-0.5.0.zip.sha256
> >,
> > PGP
> > <
> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/apache-nlpcraft-incubating-0.5.0.zip.sig
> >
> > )
> > 2. GitHub v0.5.0 tag
> > <
> https://gitbox.apache.org/repos/asf?p=incubator-nlpcraft.git;a=tag;h=refs/tags/v0.5.0
> >
> > 3. JIRA resolved issues <http:///>
> >
> > The vote is formal, see voting guidelines here:
> > https://www.apache.org/foundation/voting.html
> > +1 - to accept Apache NLPCraft 0.5.0
> > 0 - don't care either way
> > -1 - DO NOT accept Apache NLPCraft 0.5.0 (explain why)
> >
> > See notes on how to verify release here:
> > https://www.apache.org/info/verification.html
> >
> > The vote will be held for 72 hours and will end on April 3rd 2020 at
> > midnight MSK.
> >
> > Thank you!
> > --
> > Aaron Radzinski
> >
>
Re: [VOTE] Release Apache NLPCraft 0.5.0
Posted by Nikita Ivanov <ni...@gmail.com>.
NLPCraft-ers,
Just a clarification (especially, for those who are new to ASF process) -
the proposed release needs to be verified by everyone who's voting
(whenever possible) so that we can catch these errors quickly. Typically,
you need to verify:
- signatures (https://www.apache.org/info/verification.html)
- tests
- examples + major functional areas
- license, notice and disclaimer files
- license headers in the sources
- any other *common sense* checks
Thanks,
--
Nikita Ivanov
On Thu, Apr 2, 2020 at 12:00 PM Sergey Kamov <sk...@gmail.com> wrote:
> -1
>
> Sorry for previous email
>
> 1) Test suite isn't passed
> All tests passed one by one, but not in suite. "mvn verify" detected 4
> errors.
>
> [ERROR] Failures:
> [ERROR] NCDslTest.test:58 expected: <true> but was: <false>
> [ERROR] Errors:
> [ERROR] NCEnricherLimitSpec.test:33->NCEnricherBaseSpec.runBatch:135 »
> TestFailed Fail...
> [ERROR]
> NCEnricherNestedModelSpec.test:31->NCEnricherBaseSpec.runBatch:135 »
> TestFailed
> [ERROR] NCEnricherRelationSpec.test:33->NCEnricherBaseSpec.runBatch:135
> » TestFailed F...
> [ERROR] NCEnricherSortSpec.test:33->NCEnricherBaseSpec.runBatch:135 »
> TestFailed Faile...
>
> 2) Unexpected zip file signature.
>
> >> gpg --verify apache-nlpcraft-incubating-0.5.0.zip.sig
> apache-nlpcraft-incubating-0.5.0.zip
>
> gpg: Signature made Tue Mar 31 09:38:06 2020 MSK
> gpg: using RSA key 8EF51E7DC4DF1D751B82C77D3C47CC3F3F4CB613
> gpg: Good signature from "DataLingvo <in...@datalingvo.com>" [unknown]
> gpg: WARNING: This key is not certified with a trusted signature!
> gpg: There is no indication that the signature belongs to the
> owner.
> Primary key fingerprint: 8EF5 1E7D C4DF 1D75 1B82 C77D 3C47 CC3F 3F4C B613
>
>
> .
>
> 31.03.2020 23:29, Aaron Radzinski пишет:
> > NLPCraft-ers,
> > Our first ASF release is ready and up for the vote:
> > 1. ZIP tarball
> > <
> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/apache-nlpcraft-incubating-0.5.0.zip
> >
> > (SHA256
> > <
> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/apache-nlpcraft-incubating-0.5.0.zip.sha256
> >,
> > PGP
> > <
> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/apache-nlpcraft-incubating-0.5.0.zip.sig
> >
> > )
> > 2. GitHub v0.5.0 tag
> > <
> https://gitbox.apache.org/repos/asf?p=incubator-nlpcraft.git;a=tag;h=refs/tags/v0.5.0
> >
> > 3. JIRA resolved issues <http:///>
> >
> > The vote is formal, see voting guidelines here:
> > https://www.apache.org/foundation/voting.html
> > +1 - to accept Apache NLPCraft 0.5.0
> > 0 - don't care either way
> > -1 - DO NOT accept Apache NLPCraft 0.5.0 (explain why)
> >
> > See notes on how to verify release here:
> > https://www.apache.org/info/verification.html
> >
> > The vote will be held for 72 hours and will end on April 3rd 2020 at
> > midnight MSK.
> >
> > Thank you!
> > --
> > Aaron Radzinski
> >
>
Re: [VOTE] Release Apache NLPCraft 0.5.0
Posted by Sergey Kamov <sk...@gmail.com>.
-1
Sorry for previous email
1) Test suite isn't passed
All tests passed one by one, but not in suite. "mvn verify" detected 4
errors.
[ERROR] Failures:
[ERROR] NCDslTest.test:58 expected: <true> but was: <false>
[ERROR] Errors:
[ERROR] NCEnricherLimitSpec.test:33->NCEnricherBaseSpec.runBatch:135 »
TestFailed Fail...
[ERROR]
NCEnricherNestedModelSpec.test:31->NCEnricherBaseSpec.runBatch:135 »
TestFailed
[ERROR] NCEnricherRelationSpec.test:33->NCEnricherBaseSpec.runBatch:135
» TestFailed F...
[ERROR] NCEnricherSortSpec.test:33->NCEnricherBaseSpec.runBatch:135 »
TestFailed Faile...
2) Unexpected zip file signature.
>> gpg --verify apache-nlpcraft-incubating-0.5.0.zip.sig
apache-nlpcraft-incubating-0.5.0.zip
gpg: Signature made Tue Mar 31 09:38:06 2020 MSK
gpg: using RSA key 8EF51E7DC4DF1D751B82C77D3C47CC3F3F4CB613
gpg: Good signature from "DataLingvo <in...@datalingvo.com>" [unknown]
gpg: WARNING: This key is not certified with a trusted signature!
gpg: There is no indication that the signature belongs to the
owner.
Primary key fingerprint: 8EF5 1E7D C4DF 1D75 1B82 C77D 3C47 CC3F 3F4C B613
.
31.03.2020 23:29, Aaron Radzinski пишет:
> NLPCraft-ers,
> Our first ASF release is ready and up for the vote:
> 1. ZIP tarball
> <https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/apache-nlpcraft-incubating-0.5.0.zip>
> (SHA256
> <https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/apache-nlpcraft-incubating-0.5.0.zip.sha256>,
> PGP
> <https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/apache-nlpcraft-incubating-0.5.0.zip.sig>
> )
> 2. GitHub v0.5.0 tag
> <https://gitbox.apache.org/repos/asf?p=incubator-nlpcraft.git;a=tag;h=refs/tags/v0.5.0>
> 3. JIRA resolved issues <http:///>
>
> The vote is formal, see voting guidelines here:
> https://www.apache.org/foundation/voting.html
> +1 - to accept Apache NLPCraft 0.5.0
> 0 - don't care either way
> -1 - DO NOT accept Apache NLPCraft 0.5.0 (explain why)
>
> See notes on how to verify release here:
> https://www.apache.org/info/verification.html
>
> The vote will be held for 72 hours and will end on April 3rd 2020 at
> midnight MSK.
>
> Thank you!
> --
> Aaron Radzinski
>
Re: [VOTE] Release Apache NLPCraft 0.5.0
Posted by Nikita Ivanov <ni...@gmail.com>.
Some links didn't get formatted properly in the email. JIRA link for the
resolved issues is
https://issues.apache.org/jira/projects/NLPCRAFT/versions/12347774
+1 (binding)
Good job!
--
Nikita Ivanov
On Tue, Mar 31, 2020 at 1:30 PM Aaron Radzinski <ar...@datalingvo.com>
wrote:
> NLPCraft-ers,
> Our first ASF release is ready and up for the vote:
> 1. ZIP tarball
> <
> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/apache-nlpcraft-incubating-0.5.0.zip
> >
> (SHA256
> <
> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/apache-nlpcraft-incubating-0.5.0.zip.sha256
> >,
> PGP
> <
> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/apache-nlpcraft-incubating-0.5.0.zip.sig
> >
> )
> 2. GitHub v0.5.0 tag
> <
> https://gitbox.apache.org/repos/asf?p=incubator-nlpcraft.git;a=tag;h=refs/tags/v0.5.0
> >
> 3. JIRA resolved issues <http:///>
>
> The vote is formal, see voting guidelines here:
> https://www.apache.org/foundation/voting.html
> +1 - to accept Apache NLPCraft 0.5.0
> 0 - don't care either way
> -1 - DO NOT accept Apache NLPCraft 0.5.0 (explain why)
>
> See notes on how to verify release here:
> https://www.apache.org/info/verification.html
>
> The vote will be held for 72 hours and will end on April 3rd 2020 at
> midnight MSK.
>
> Thank you!
> --
> Aaron Radzinski
>
Re: [VOTE] Release Apache NLPCraft 0.5.0
Posted by Dave Fisher <wa...@apache.org>.
> On Mar 31, 2020, at 1:29 PM, Aaron Radzinski <ar...@datalingvo.com> wrote:
>
> NLPCraft-ers,
> Our first ASF release is ready and up for the vote:
> 1. ZIP tarball
> <https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/apache-nlpcraft-incubating-0.5.0.zip>
> (SHA256
> <https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/apache-nlpcraft-incubating-0.5.0.zip.sha256>,
> PGP
> <https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/apache-nlpcraft-incubating-0.5.0.zip.sig>
Signature must have the “asc” extension. See the verification link.
Regards,
Dave
> )
> 2. GitHub v0.5.0 tag
> <https://gitbox.apache.org/repos/asf?p=incubator-nlpcraft.git;a=tag;h=refs/tags/v0.5.0>
> 3. JIRA resolved issues <http:///>
>
> The vote is formal, see voting guidelines here:
> https://www.apache.org/foundation/voting.html
> +1 - to accept Apache NLPCraft 0.5.0
> 0 - don't care either way
> -1 - DO NOT accept Apache NLPCraft 0.5.0 (explain why)
>
> See notes on how to verify release here:
> https://www.apache.org/info/verification.html
>
> The vote will be held for 72 hours and will end on April 3rd 2020 at
> midnight MSK.
>
> Thank you!
> --
> Aaron Radzinski