You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/09/09 10:43:34 UTC

[GitHub] [incubator-seatunnel] Carl-Zhou-CN opened a new pull request, #2705: [Bug][seatunnel-connector-spark-tidb] Spark tidb Connector Hadoop dependency excluded

Carl-Zhou-CN opened a new pull request, #2705:
URL: https://github.com/apache/incubator-seatunnel/pull/2705

   <!--
   
   Thank you for contributing to SeaTunnel! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
    [2698](https://github.com/apache/incubator-seatunnel/issues/2698)
     - Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
   
     - Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
   
   -->
   
   ## Purpose of this pull request
   
   <!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
   
   ## Check list
   
   * [ ] Code changed are covered with tests, or it does not need tests for reason:
   * [ ] If any new Jar binary package adding in your PR, please add License Notice according
     [New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
   * [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] Carl-Zhou-CN commented on pull request #2705: [Bug][seatunnel-connector-spark-tidb] Spark tidb Connector Hadoop dependency excluded

Posted by GitBox <gi...@apache.org>.
Carl-Zhou-CN commented on PR #2705:
URL: https://github.com/apache/incubator-seatunnel/pull/2705#issuecomment-1245054135

   @hailin0 I didn't find anything about TiDB in E2E, do I need to add a module for this? If so, I can try, and how can this PR review be approved to begin


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] hailin0 commented on a diff in pull request #2705: [Bug][seatunnel-connector-spark-tidb] Spark tidb Connector Hadoop dependency excluded

Posted by GitBox <gi...@apache.org>.
hailin0 commented on code in PR #2705:
URL: https://github.com/apache/incubator-seatunnel/pull/2705#discussion_r983022239


##########
seatunnel-e2e/seatunnel-spark-e2e/seatunnel-connector-spark-tidb-e2e/src/test/resources/tidb/tidb_source_and_sink.conf:
##########
@@ -0,0 +1,54 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+env {
+    # You can set spark configuration here
+    spark.app.name = "SeaTunnel"
+    spark.executor.instances = 2
+    spark.executor.cores = 1
+    spark.executor.memory = "1g"
+    spark.master = local
+    job.mode = "BATCH"
+    spark.tispark.pd.addresses = "127.0.0.1:2379"
+    spark.sql.extensions = "org.apache.spark.sql.TiExtensions"
+}
+
+source {
+
+    tidb {
+        database = "test"
+        pre_sql = "select * from test.e2e_table_source"
+        result_table_name = "spark_test"
+    }
+}
+
+transform {
+
+}
+
+sink {
+
+    tidb {
+        addr = "127.0.0.1"

Review Comment:
   You can use the container to start all dependencies
   
   reference
   https://github.com/apache/incubator-seatunnel/pull/2830/files#diff-813f5496f69f3fe1d81254c15504b8c5ea36ec8f9fb2bd90c600429de401a3daR72



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] Carl-Zhou-CN closed pull request #2705: [Bug][seatunnel-connector-spark-tidb] Spark tidb Connector Hadoop dependency excluded

Posted by GitBox <gi...@apache.org>.
Carl-Zhou-CN closed pull request #2705: [Bug][seatunnel-connector-spark-tidb] Spark tidb Connector Hadoop dependency excluded
URL: https://github.com/apache/incubator-seatunnel/pull/2705


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] hailin0 commented on a diff in pull request #2705: [Bug][seatunnel-connector-spark-tidb] Spark tidb Connector Hadoop dependency excluded

Posted by GitBox <gi...@apache.org>.
hailin0 commented on code in PR #2705:
URL: https://github.com/apache/incubator-seatunnel/pull/2705#discussion_r974022881


##########
seatunnel-e2e/seatunnel-spark-e2e/seatunnel-connector-spark-tidb-e2e/src/test/resources/tidb/tidb_source_and_sink.conf:
##########
@@ -0,0 +1,54 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+env {
+    # You can set spark configuration here
+    spark.app.name = "SeaTunnel"
+    spark.executor.instances = 2
+    spark.executor.cores = 1
+    spark.executor.memory = "1g"
+    spark.master = local
+    job.mode = "BATCH"
+    spark.tispark.pd.addresses = "127.0.0.1:2379"
+    spark.sql.extensions = "org.apache.spark.sql.TiExtensions"
+}
+
+source {
+
+    tidb {
+        database = "test"
+        pre_sql = "select * from test.e2e_table_source"
+        result_table_name = "spark_test"
+    }
+}
+
+transform {
+
+}
+
+sink {
+
+    tidb {
+        addr = "127.0.0.1"

Review Comment:
   use `addr  = "spark_e2e_tidb"`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] Carl-Zhou-CN commented on pull request #2705: [Bug][seatunnel-connector-spark-tidb] Spark tidb Connector Hadoop dependency excluded

Posted by GitBox <gi...@apache.org>.
Carl-Zhou-CN commented on PR #2705:
URL: https://github.com/apache/incubator-seatunnel/pull/2705#issuecomment-1317939824

   @hailin0 @Hisoka-X I'm sorry that I tried many methods to make the connection between pd and tidb impossible. I also tried to use the e2e samples of tikv contributors, but the same problem still exists. I may not be able to implement the e2e of this module, but I think my submission is meaningful for this connector


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] CalvinKirs closed pull request #2705: [Bug][seatunnel-connector-spark-tidb] Spark tidb Connector Hadoop dependency excluded

Posted by GitBox <gi...@apache.org>.
CalvinKirs closed pull request #2705: [Bug][seatunnel-connector-spark-tidb] Spark tidb Connector Hadoop dependency excluded
URL: https://github.com/apache/incubator-seatunnel/pull/2705


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #2705: [Bug][seatunnel-connector-spark-tidb] Spark tidb Connector Hadoop dependency excluded

Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on PR #2705:
URL: https://github.com/apache/incubator-seatunnel/pull/2705#issuecomment-1384918873

   hi, thanks for your contribution, dev branch will no longer maintain the V1 version of the connector, so I will close this PR,
   If you are interested in this, you can contribute the corresponding V2Connector
   https://github.com/apache/incubator-seatunnel/tree/dev/seatunnel-connectors-v2


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] hailin0 commented on a diff in pull request #2705: [Bug][seatunnel-connector-spark-tidb] Spark tidb Connector Hadoop dependency excluded

Posted by GitBox <gi...@apache.org>.
hailin0 commented on code in PR #2705:
URL: https://github.com/apache/incubator-seatunnel/pull/2705#discussion_r983022239


##########
seatunnel-e2e/seatunnel-spark-e2e/seatunnel-connector-spark-tidb-e2e/src/test/resources/tidb/tidb_source_and_sink.conf:
##########
@@ -0,0 +1,54 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+env {
+    # You can set spark configuration here
+    spark.app.name = "SeaTunnel"
+    spark.executor.instances = 2
+    spark.executor.cores = 1
+    spark.executor.memory = "1g"
+    spark.master = local
+    job.mode = "BATCH"
+    spark.tispark.pd.addresses = "127.0.0.1:2379"
+    spark.sql.extensions = "org.apache.spark.sql.TiExtensions"
+}
+
+source {
+
+    tidb {
+        database = "test"
+        pre_sql = "select * from test.e2e_table_source"
+        result_table_name = "spark_test"
+    }
+}
+
+transform {
+
+}
+
+sink {
+
+    tidb {
+        addr = "127.0.0.1"

Review Comment:
   You can use the container to start all dependencies
   
   @Carl-Zhou-CN 
   
   reference
   https://github.com/apache/incubator-seatunnel/pull/2830/files#diff-813f5496f69f3fe1d81254c15504b8c5ea36ec8f9fb2bd90c600429de401a3daR72



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] Carl-Zhou-CN commented on pull request #2705: [Bug][seatunnel-connector-spark-tidb] Spark tidb Connector Hadoop dependency excluded

Posted by GitBox <gi...@apache.org>.
Carl-Zhou-CN commented on PR #2705:
URL: https://github.com/apache/incubator-seatunnel/pull/2705#issuecomment-1244800296

   @hailin0 please help to review it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] hailin0 commented on pull request #2705: [Bug][seatunnel-connector-spark-tidb] Spark tidb Connector Hadoop dependency excluded

Posted by GitBox <gi...@apache.org>.
hailin0 commented on PR #2705:
URL: https://github.com/apache/incubator-seatunnel/pull/2705#issuecomment-1244832618

   Can you add e2e-testcase(spark)?
   
   reference
   https://github.com/apache/incubator-seatunnel/tree/dev/seatunnel-e2e/seatunnel-spark-e2e


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] hailin0 commented on a diff in pull request #2705: [Bug][seatunnel-connector-spark-tidb] Spark tidb Connector Hadoop dependency excluded

Posted by GitBox <gi...@apache.org>.
hailin0 commented on code in PR #2705:
URL: https://github.com/apache/incubator-seatunnel/pull/2705#discussion_r974022881


##########
seatunnel-e2e/seatunnel-spark-e2e/seatunnel-connector-spark-tidb-e2e/src/test/resources/tidb/tidb_source_and_sink.conf:
##########
@@ -0,0 +1,54 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+env {
+    # You can set spark configuration here
+    spark.app.name = "SeaTunnel"
+    spark.executor.instances = 2
+    spark.executor.cores = 1
+    spark.executor.memory = "1g"
+    spark.master = local
+    job.mode = "BATCH"
+    spark.tispark.pd.addresses = "127.0.0.1:2379"
+    spark.sql.extensions = "org.apache.spark.sql.TiExtensions"
+}
+
+source {
+
+    tidb {
+        database = "test"
+        pre_sql = "select * from test.e2e_table_source"
+        result_table_name = "spark_test"
+    }
+}
+
+transform {
+
+}
+
+sink {
+
+    tidb {
+        addr = "127.0.0.1"

Review Comment:
   use `spark_e2e_tidb`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] Hisoka-X commented on pull request #2705: [Bug][seatunnel-connector-spark-tidb] Spark tidb Connector Hadoop dependency excluded

Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on PR #2705:
URL: https://github.com/apache/incubator-seatunnel/pull/2705#issuecomment-1250054461

   Hi, Please fix license check and codestyle. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] Carl-Zhou-CN commented on a diff in pull request #2705: [Bug][seatunnel-connector-spark-tidb] Spark tidb Connector Hadoop dependency excluded

Posted by GitBox <gi...@apache.org>.
Carl-Zhou-CN commented on code in PR #2705:
URL: https://github.com/apache/incubator-seatunnel/pull/2705#discussion_r974039351


##########
seatunnel-e2e/seatunnel-spark-e2e/seatunnel-connector-spark-tidb-e2e/src/test/resources/tidb/tidb_source_and_sink.conf:
##########
@@ -0,0 +1,54 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+env {
+    # You can set spark configuration here
+    spark.app.name = "SeaTunnel"
+    spark.executor.instances = 2
+    spark.executor.cores = 1
+    spark.executor.memory = "1g"
+    spark.master = local
+    job.mode = "BATCH"
+    spark.tispark.pd.addresses = "127.0.0.1:2379"
+    spark.sql.extensions = "org.apache.spark.sql.TiExtensions"
+}
+
+source {
+
+    tidb {
+        database = "test"
+        pre_sql = "select * from test.e2e_table_source"
+        result_table_name = "spark_test"
+    }
+}
+
+transform {
+
+}
+
+sink {
+
+    tidb {
+        addr = "127.0.0.1"

Review Comment:
   Yes, I expect so. But now I come across a problem. It seems that I can't deploy tidb in a single docker and connect to it in the way of tispark. It lacks pd and tikv. Do you have any good suggestions?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] Carl-Zhou-CN commented on pull request #2705: [Bug][seatunnel-connector-spark-tidb] Spark tidb Connector Hadoop dependency excluded

Posted by GitBox <gi...@apache.org>.
Carl-Zhou-CN commented on PR #2705:
URL: https://github.com/apache/incubator-seatunnel/pull/2705#issuecomment-1241812430

   #2698 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org