You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Jibing-Li (via GitHub)" <gi...@apache.org> on 2023/04/13 08:24:50 UTC
[GitHub] [doris] Jibing-Li opened a new pull request, #18636: [Refactor](multi catalog)Remove redundant param context for FileQueryScanNode
Jibing-Li opened a new pull request, #18636:
URL: https://github.com/apache/doris/pull/18636
Remove redundant param context for FileQueryScanNode.
Remove duplicated code for QueryScanProviders.
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [ ] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Jibing-Li commented on pull request #18636: [Refactor](multi catalog)Remove redundant param context for FileQueryScanNode
Posted by "Jibing-Li (via GitHub)" <gi...@apache.org>.
Jibing-Li commented on PR #18636:
URL: https://github.com/apache/doris/pull/18636#issuecomment-1507980046
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18636: [Refactor](multi catalog)Remove redundant param context for FileQueryScanNode
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18636:
URL: https://github.com/apache/doris/pull/18636#issuecomment-1508419599
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18636: [Refactor](multi catalog)Remove redundant param context for FileQueryScanNode
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18636:
URL: https://github.com/apache/doris/pull/18636#issuecomment-1508419662
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Jibing-Li commented on pull request #18636: [Refactor](multi catalog)Remove redundant param context for FileQueryScanNode
Posted by "Jibing-Li (via GitHub)" <gi...@apache.org>.
Jibing-Li commented on PR #18636:
URL: https://github.com/apache/doris/pull/18636#issuecomment-1507876739
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Jibing-Li commented on pull request #18636: [Refactor](multi catalog)Remove redundant param context for FileQueryScanNode
Posted by "Jibing-Li (via GitHub)" <gi...@apache.org>.
Jibing-Li commented on PR #18636:
URL: https://github.com/apache/doris/pull/18636#issuecomment-1507282249
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman merged pull request #18636: [Refactor](multi catalog)Remove redundant param context for FileQueryScanNode
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman merged PR #18636:
URL: https://github.com/apache/doris/pull/18636
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #18636: [Refactor](multi catalog)Remove redundant param context for FileQueryScanNode
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on code in PR #18636:
URL: https://github.com/apache/doris/pull/18636#discussion_r1165546876
##########
fe/fe-core/src/main/java/org/apache/doris/planner/external/FileQueryScanNode.java:
##########
@@ -114,9 +116,10 @@ public void init() throws UserException {
backendPolicy.init();
numNodes = backendPolicy.numBackends();
- context = scanProvider.createContext(analyzer);
- context.createDestSlotMap();
- context.conjuncts = conjuncts;
+ initParamCreateContexts();
+ // context = scanProvider.createContext(analyzer);
Review Comment:
delete if unused.
##########
fe/fe-core/src/main/java/org/apache/doris/planner/external/FileQueryScanNode.java:
##########
@@ -203,24 +206,40 @@ private void initFunctionGenTable(FunctionGenTable table, ExternalFileTableValue
}
// Create a corresponding ParamCreateContext
- private void initParamCreateContexts(Analyzer analyzer) throws UserException {
- context = scanProvider.createContext(analyzer);
- context.createDestSlotMap();
- context.conjuncts = conjuncts;
+ private void initParamCreateContexts() throws UserException {
Review Comment:
The method name should be changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org