You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/04/27 00:10:01 UTC
[GitHub] [tvm] jwfromm opened a new pull request #7929: [Topi] Fix arm_cpu bitserial schedule with elemwise ops.
jwfromm opened a new pull request #7929:
URL: https://github.com/apache/tvm/pull/7929
As noted in #7909, the arm bitserial_conv2d schedule has issues with fused elemwise operators. This turned out to be due to a simple mistake that this PR corrects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] bernhardklein commented on pull request #7929: [Topi] Fix arm_cpu bitserial schedule with elemwise ops.
Posted by GitBox <gi...@apache.org>.
bernhardklein commented on pull request #7929:
URL: https://github.com/apache/tvm/pull/7929#issuecomment-827404288
@jwfromm seems to work. I could not test it with your branch directly, because I can't compile TVM with it. Cmake complains about something with libbacktrace. However, using your bitserial_conv2d.py file with a current TVM checkout works well and solves the issue.
@jwfromm and @comaniac thank you very much!
Should I close the [issue #7909](https://github.com/apache/tvm/issues/7909) or wait till the merge is done?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jwfromm commented on pull request #7929: [Topi] Fix arm_cpu bitserial schedule with elemwise ops.
Posted by GitBox <gi...@apache.org>.
jwfromm commented on pull request #7929:
URL: https://github.com/apache/tvm/pull/7929#issuecomment-827224609
Yes, just added a test that confirms the issue is resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] bernhardklein commented on pull request #7929: [Topi] Fix arm_cpu bitserial schedule with elemwise ops.
Posted by GitBox <gi...@apache.org>.
bernhardklein commented on pull request #7929:
URL: https://github.com/apache/tvm/pull/7929#issuecomment-827769309
@jwfromm oh yes, you are right libbacktrace was missing and after a `git submodule init`-> `git submodule update` I could compile TVM and further the bit serial ReLU test model works now with your branch.
So the issue seems to be solved. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jwfromm commented on pull request #7929: [Topi] Fix arm_cpu bitserial schedule with elemwise ops.
Posted by GitBox <gi...@apache.org>.
jwfromm commented on pull request #7929:
URL: https://github.com/apache/tvm/pull/7929#issuecomment-827218254
@bernhardklein can you give this PR a shot to confirm everything now works as expected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] comaniac commented on pull request #7929: [Topi] Fix arm_cpu bitserial schedule with elemwise ops.
Posted by GitBox <gi...@apache.org>.
comaniac commented on pull request #7929:
URL: https://github.com/apache/tvm/pull/7929#issuecomment-827767443
> Should I close the [issue #7909](https://github.com/apache/tvm/issues/7909) or wait till the merge is done?
I've linked this PR to the issue, so once this PR is merged the issue will be closed automatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen merged pull request #7929: [Topi] Fix arm_cpu bitserial schedule with elemwise ops.
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #7929:
URL: https://github.com/apache/tvm/pull/7929
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jcf94 commented on pull request #7929: [Topi] Fix arm_cpu bitserial schedule with elemwise ops.
Posted by GitBox <gi...@apache.org>.
jcf94 commented on pull request #7929:
URL: https://github.com/apache/tvm/pull/7929#issuecomment-828151207
Some error occured. @jwfromm Seems you need to push again to re-triggle the CI...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jwfromm commented on pull request #7929: [Topi] Fix arm_cpu bitserial schedule with elemwise ops.
Posted by GitBox <gi...@apache.org>.
jwfromm commented on pull request #7929:
URL: https://github.com/apache/tvm/pull/7929#issuecomment-827718556
@bernhardklein, I think libbacktrace was recently added to TVM, you may need to do a `git submodule init` -> `git submodule update` to grab it. Waiting for this to merge before closing the issue should be fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org