[GitHub] [incubator-druid] asdf2014 commented on a change in pull request #8022: Enable Spotbugs: MS_OOI_PKGPROTECT

[GitBox <gi...@apache.org>]

asdf2014 commented on a change in pull request #8022: Enable Spotbugs: MS_OOI_PKGPROTECT
URL: https://github.com/apache/incubator-druid/pull/8022#discussion_r300209621
 
 

 ##########
 File path: processing/src/main/java/org/apache/druid/query/metadata/metadata/AllColumnIncluderator.java
 ##########
 @@ -32,7 +32,7 @@ public boolean include(String columnName)
   @Override
   public byte[] getCacheKey()
   {
-    return ALL_CACHE_PREFIX;
+    return new byte[]{0x1};
 
 Review comment:
   It would be better to store these byte arrays as static fields in the subclass of `ColumnIncluderator`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org