You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/01/31 16:10:41 UTC
[GitHub] [cloudstack] ustcweizhou opened a new pull request #3857: vr: add
missing rule for port forwarding rule in vpc
ustcweizhou opened a new pull request #3857: vr: add missing rule for port forwarding rule in vpc
URL: https://github.com/apache/cloudstack/pull/3857
## Description
<!--- Describe your changes in detail -->
When create a port forwarding rule to a vm in vpc, we cannot access the port forwarding rule from inside the vm.
Steps to reproduce
(1) create a port forwarding rule in VPC, public ip X.X.X.X to vm Y.Y.Y.Y port 22
(2) ssh to vm, or login vm console
(3) in vm, ssh X.X.X.X does not work.
Fixes: #3763
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
with this change, the public Ip is reachable from inside vm in step (3) above.
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3857: vr: add missing
rule for port forwarding rule in vpc
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3857: vr: add missing rule for port forwarding rule in vpc
URL: https://github.com/apache/cloudstack/pull/3857#issuecomment-581374761
@weizhouapache (cc @rhtyd ) it is a pylint format error. you care to fix?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3857: vr: add missing rule
for port forwarding rule in vpc
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3857: vr: add missing rule for port forwarding rule in vpc
URL: https://github.com/apache/cloudstack/pull/3857#issuecomment-580996549
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3857: vr: add
missing rule for port forwarding rule in vpc
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3857: vr: add missing rule for port forwarding rule in vpc
URL: https://github.com/apache/cloudstack/pull/3857#issuecomment-582826866
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3857: vr: add missing rule
for port forwarding rule in vpc
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3857: vr: add missing rule for port forwarding rule in vpc
URL: https://github.com/apache/cloudstack/pull/3857#issuecomment-582826418
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3857: vr: add missing
rule for port forwarding rule in vpc
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3857: vr: add missing rule for port forwarding rule in vpc
URL: https://github.com/apache/cloudstack/pull/3857#issuecomment-582954923
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3857: vr: add
missing rule for port forwarding rule in vpc
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3857: vr: add missing rule for port forwarding rule in vpc
URL: https://github.com/apache/cloudstack/pull/3857#issuecomment-582837171
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-769
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3857: vr: add
missing rule for port forwarding rule in vpc
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3857: vr: add missing rule for port forwarding rule in vpc
URL: https://github.com/apache/cloudstack/pull/3857#issuecomment-580814455
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on a change in pull request
#3857: vr: add missing rule for port forwarding rule in vpc
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #3857: vr: add missing rule for port forwarding rule in vpc
URL: https://github.com/apache/cloudstack/pull/3857#discussion_r375693925
##########
File path: systemvm/debian/opt/cloud/bin/configure.py
##########
@@ -930,8 +936,20 @@ def forward_vpc(self, rule):
if not rule["internal_ports"] == "any":
fw_output_rule += ":" + self.portsToString(rule["internal_ports"], "-")
+ fw_postrout_rule2 = "-j SNAT --to-source %s -A POSTROUTING -s %s -d %s/32 -o %s -p %s -m %s --dport %s" % \
+ (
Review comment:
@rhtyd
checks should be ok now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3857: vr: add missing rule
for port forwarding rule in vpc
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3857: vr: add missing rule for port forwarding rule in vpc
URL: https://github.com/apache/cloudstack/pull/3857#issuecomment-581313360
Rekicked Travis job1, it failed; need to check if it fails again cc @ustcweizhou
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3857: vr: add missing rule
for port forwarding rule in vpc
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3857: vr: add missing rule for port forwarding rule in vpc
URL: https://github.com/apache/cloudstack/pull/3857#issuecomment-580814217
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3857: vr: add
missing rule for port forwarding rule in vpc
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3857: vr: add missing rule for port forwarding rule in vpc
URL: https://github.com/apache/cloudstack/pull/3857#issuecomment-580822201
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-734
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland merged pull request #3857: vr: add
missing rule for port forwarding rule in vpc
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged pull request #3857: vr: add missing rule for port forwarding rule in vpc
URL: https://github.com/apache/cloudstack/pull/3857
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3857: vr: add
missing rule for port forwarding rule in vpc
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3857: vr: add missing rule for port forwarding rule in vpc
URL: https://github.com/apache/cloudstack/pull/3857#issuecomment-580996668
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3857: vr: add
missing rule for port forwarding rule in vpc
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3857: vr: add missing rule for port forwarding rule in vpc
URL: https://github.com/apache/cloudstack/pull/3857#issuecomment-583167090
<b>Trillian test result (tid-914)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 28627 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3857-t914-kvm-centos7.zip
Smoke tests completed. 77 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3857: vr: add
missing rule for port forwarding rule in vpc
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3857: vr: add missing rule for port forwarding rule in vpc
URL: https://github.com/apache/cloudstack/pull/3857#issuecomment-581033641
<b>Trillian test result (tid-873)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 28507 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3857-t873-kvm-centos7.zip
Smoke tests completed. 77 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3857: vr: add
missing rule for port forwarding rule in vpc
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3857: vr: add missing rule for port forwarding rule in vpc
URL: https://github.com/apache/cloudstack/pull/3857#issuecomment-582955085
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on a change in pull request #3857: vr:
add missing rule for port forwarding rule in vpc
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #3857: vr: add missing rule for port forwarding rule in vpc
URL: https://github.com/apache/cloudstack/pull/3857#discussion_r375651344
##########
File path: systemvm/debian/opt/cloud/bin/configure.py
##########
@@ -930,8 +936,20 @@ def forward_vpc(self, rule):
if not rule["internal_ports"] == "any":
fw_output_rule += ":" + self.portsToString(rule["internal_ports"], "-")
+ fw_postrout_rule2 = "-j SNAT --to-source %s -A POSTROUTING -s %s -d %s/32 -o %s -p %s -m %s --dport %s" % \
+ (
Review comment:
@ustcweizhou can you fix the indent issue here, run `pycodestyle --max-line-length=179` on this file to confirm. See Travis' 1st job failure for hints: `../debian/opt/cloud/bin/configure.py:940:15: E127 continuation line over-indented for visual indent`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services