You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "xixingya (via GitHub)" <gi...@apache.org> on 2023/07/14 11:27:47 UTC

[GitHub] [dubbo] xixingya commented on a diff in pull request #12671: fix log level is null in Slf4j and fix not valid in Log4j2

xixingya commented on code in PR #12671:
URL: https://github.com/apache/dubbo/pull/12671#discussion_r1263623946


##########
dubbo-common/src/main/java/org/apache/dubbo/common/logger/slf4j/Slf4jLoggerAdapter.java:
##########
@@ -45,6 +52,7 @@ public Level getLevel() {
 
     @Override
     public void setLevel(Level level) {
+        getLogger(Slf4jLoggerAdapter.class).warn(String.format("The level of slf4j logger can not be set, using the default level: %s",Slf4jLogger.getLevel(ROOT_LOGGER)));

Review Comment:
   hello,I just fix,can you take a look?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org