You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by sujith71955 <gi...@git.apache.org> on 2018/09/21 09:39:40 UTC

[GitHub] spark pull request #22466: [SPARK-25464][SQL]On dropping the Database it wil...

Github user sujith71955 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22466#discussion_r219440456
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
    @@ -67,12 +67,15 @@ case class CreateDatabaseCommand(
     
       override def run(sparkSession: SparkSession): Seq[Row] = {
         val catalog = sparkSession.sessionState.catalog
    +    // if the path is specified by the user then need to consider DB as external DB
    +    // User will take care of deleting the path after DB is dropped
    --- End diff --
    
    nit: user shall  take care of deleting the data from external location.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org