[GitHub] [fineract] reluxa commented on a diff in pull request #3218: FINERACT-1724: Datatables query API fix - invalid tablename

["reluxa (via GitHub)" <gi...@apache.org>]

reluxa commented on code in PR #3218:
URL: https://github.com/apache/fineract/pull/3218#discussion_r1217562036


##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/ReadWriteNonCoreDataServiceImpl.java:
##########
@@ -1859,6 +1860,14 @@ private String queryForApplicationTableName(final String datatable) {
         return applicationTableName;
     }
 
+    private void validateDatatable(final String datatable) {
+        final String sql = "SELECT application_table_name FROM x_registered_table where registered_table_name = ?";

Review Comment:
   I would have used 
   ```
   SELECT count(application_table_name) FROM x_registered_table where registered_table_name = ?
   ```
   here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org