You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-commits@jackrabbit.apache.org by mr...@apache.org on 2013/05/13 15:21:12 UTC
svn commit: r1481838 - in /jackrabbit/oak/trunk/oak-jcr/src:
main/java/org/apache/jackrabbit/oak/jcr/PropertyImpl.java
test/java/org/apache/jackrabbit/oak/jcr/version/VersionableTest.java
Author: mreutegg
Date: Mon May 13 13:21:12 2013
New Revision: 1481838
URL: http://svn.apache.org/r1481838
Log:
OAK-815: Wrong type for empty multi-valued property
Added:
jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/version/VersionableTest.java (with props)
Modified:
jackrabbit/oak/trunk/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/PropertyImpl.java
Modified: jackrabbit/oak/trunk/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/PropertyImpl.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/PropertyImpl.java?rev=1481838&r1=1481837&r2=1481838&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/PropertyImpl.java (original)
+++ jackrabbit/oak/trunk/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/PropertyImpl.java Mon May 13 13:21:12 2013
@@ -393,7 +393,10 @@ public class PropertyImpl extends ItemIm
Value[] values = getValues();
if (values.length == 0) {
// retrieve the type from the property definition
- PropertyDefinition definition = internalGetDefinition();
+ // do not require exact match (see OAK-815)
+ PropertyDefinition definition = getDefinitionProvider()
+ .getDefinition(dlg.getParent().getTree(),
+ dlg.getPropertyState(), false);
if (definition.getRequiredType() == PropertyType.UNDEFINED) {
return PropertyType.STRING;
} else {
Added: jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/version/VersionableTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/version/VersionableTest.java?rev=1481838&view=auto
==============================================================================
--- jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/version/VersionableTest.java (added)
+++ jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/version/VersionableTest.java Mon May 13 13:21:12 2013
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.jackrabbit.oak.jcr.version;
+
+import javax.jcr.Node;
+import javax.jcr.PropertyType;
+import javax.jcr.RepositoryException;
+import javax.jcr.version.VersionManager;
+
+import org.apache.jackrabbit.test.AbstractJCRTest;
+
+/**
+ * <code>VersionableTest</code> contains tests for method relevant to
+ * versionable nodes.
+ */
+public class VersionableTest extends AbstractJCRTest {
+
+ public void testGetTypeOfPredecessors() throws RepositoryException {
+ Node node = testRootNode.addNode(nodeName1, testNodeType);
+ node.addMixin(mixVersionable);
+ superuser.save();
+ VersionManager vMgr = superuser.getWorkspace().getVersionManager();
+ vMgr.checkin(node.getPath());
+ assertEquals(PropertyType.nameFromValue(PropertyType.REFERENCE),
+ PropertyType.nameFromValue(node.getProperty(jcrPredecessors).getType()));
+ }
+}
Propchange: jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/version/VersionableTest.java
------------------------------------------------------------------------------
svn:eol-style = native
Propchange: jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/version/VersionableTest.java
------------------------------------------------------------------------------
svn:keywords = Author Date Id Revision Rev URL