You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/04/22 10:02:34 UTC
[GitHub] [ignite] eadha opened a new pull request #9035: ignite-14600 ssl test for thin client, handshake issue
eadha opened a new pull request #9035:
URL: https://github.com/apache/ignite/pull/9035
SSL connection test for thin client.
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] eadha closed pull request #9035: ignite-14600 ssl test for thin client, handshake issue
Posted by GitBox <gi...@apache.org>.
eadha closed pull request #9035:
URL: https://github.com/apache/ignite/pull/9035
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] eadha commented on pull request #9035: ignite-14600 ssl test for thin client, handshake issue
Posted by GitBox <gi...@apache.org>.
eadha commented on pull request #9035:
URL: https://github.com/apache/ignite/pull/9035#issuecomment-830103701
new one was raised
https://github.com/apache/ignite/pull/9071/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] nizhikov commented on a change in pull request #9035: ignite-14600 ssl test for thin client, handshake issue
Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #9035:
URL: https://github.com/apache/ignite/pull/9035#discussion_r623803917
##########
File path: modules/ducktests/tests/ignitetest/tests/thin_client_test.py
##########
@@ -32,6 +32,11 @@ class ThinClientTest(IgniteTest):
"""
cluster - cluster size.
JAVA_CLIENT_CLASS_NAME - running classname.
+ to use with ssl enabled:
+ export GLOBALS='{"ssl":{"enabled":true},"key_store_path":"/opt/ignite-dev/modules/ducktests/tests/certs/",
Review comment:
Actually, we don't need anything except "ssl:enabled:true".
Please, fix the doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] nizhikov commented on a change in pull request #9035: ignite-14600 ssl test for thin client, handshake issue
Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #9035:
URL: https://github.com/apache/ignite/pull/9035#discussion_r623803356
##########
File path: modules/ducktests/tests/ignitetest/services/utils/templates/ignite.xml.j2
##########
@@ -80,10 +80,11 @@
{% endif %}
{% if config.ssl_params %}
- <property name="sslContextFactory">
- {{ ssl_params_util.ssl_params(config.ssl_params) }}
- </property>
- {% endif %}
+ <property name="sslContextFactory">
Review comment:
Why this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org