You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "AngersZhuuuu (via GitHub)" <gi...@apache.org> on 2023/04/21 10:07:12 UTC
[GitHub] [incubator-celeborn] AngersZhuuuu opened a new pull request, #1446: [CELEBORN-543][PERF] handleUnregisterShuffle may occupy RPC thread
AngersZhuuuu opened a new pull request, #1446:
URL: https://github.com/apache/incubator-celeborn/pull/1446
### What changes were proposed in this pull request?
Fix handleUnregisterShuffle may occupy RPC thread
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] AngersZhuuuu commented on pull request #1446: [CELEBORN-543][PERF] handleUnregisterShuffle may occupy RPC thread
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on PR #1446:
URL: https://github.com/apache/incubator-celeborn/pull/1446#issuecomment-1517604411
ping @RexXiong @waitinfuture
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1446: [CELEBORN-543][PERF] handleUnregisterShuffle may occupy RPC thread
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1446:
URL: https://github.com/apache/incubator-celeborn/pull/1446#issuecomment-1517611630
## [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1446?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1446](https://codecov.io/gh/apache/incubator-celeborn/pull/1446?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (188a66a) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/e3ae2f0e17939ed7f765edea248b55d641603600?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e3ae2f0) will **decrease** coverage by `0.03%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #1446 +/- ##
==========================================
- Coverage 44.87% 44.84% -0.03%
==========================================
Files 156 156
Lines 9596 9596
Branches 956 956
==========================================
- Hits 4305 4302 -3
- Misses 5008 5011 +3
Partials 283 283
```
[see 1 file with indirect coverage changes](https://codecov.io/gh/apache/incubator-celeborn/pull/1446/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture commented on pull request #1446: [CELEBORN-543][PERF] handleUnregisterShuffle may occupy RPC thread
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on PR #1446:
URL: https://github.com/apache/incubator-celeborn/pull/1446#issuecomment-1520080133
IMO it's not a good idea to call ```lifecycleManager.unregisterShuffle(shuffleId, true)``` in ```setStageEnd```, because they are separate events, and in most cases unregister shuffle happens after stage end, so I think it's rare that ```handleUnregisterShuffle``` encounters that ```isStageEnd``` is false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] AngersZhuuuu commented on pull request #1446: [CELEBORN-543][PERF] handleUnregisterShuffle may occupy RPC thread
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on PR #1446:
URL: https://github.com/apache/incubator-celeborn/pull/1446#issuecomment-1519907706
ping @pan3793 @waitinfuture @RexXiong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] AngersZhuuuu closed pull request #1446: [CELEBORN-543][PERF] handleUnregisterShuffle may occupy RPC thread
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu closed pull request #1446: [CELEBORN-543][PERF] handleUnregisterShuffle may occupy RPC thread
URL: https://github.com/apache/incubator-celeborn/pull/1446
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org