You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/06/14 16:56:26 UTC
[GitHub] codecov-io commented on issue #5189: [druid] remove reliance on
coordinator
codecov-io commented on issue #5189: [druid] remove reliance on coordinator
URL: https://github.com/apache/incubator-superset/pull/5189#issuecomment-397365458
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5189?src=pr&el=h1) Report
> Merging [#5189](https://codecov.io/gh/apache/incubator-superset/pull/5189?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a1095437bc11fa29986f8d283a887d44343b22d3?src=pr&el=desc) will **increase** coverage by `13.92%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/5189?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5189 +/- ##
===========================================
+ Coverage 63.45% 77.38% +13.92%
===========================================
Files 261 44 -217
Lines 19822 8726 -11096
Branches 1989 0 -1989
===========================================
- Hits 12579 6753 -5826
+ Misses 7234 1973 -5261
+ Partials 9 0 -9
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5189?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/connectors/druid/views.py](https://codecov.io/gh/apache/incubator-superset/pull/5189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `68.02% <ø> (ø)` | :arrow_up: |
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/5189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `80.42% <100%> (-0.08%)` | :arrow_down: |
| [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/5189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `52.89% <0%> (-0.83%)` | :arrow_down: |
| [superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/5189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=) | `88.31% <0%> (-0.21%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/5189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `81.29% <0%> (-0.04%)` | :arrow_down: |
| [superset/data/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/5189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YS9fX2luaXRfXy5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [superset/assets/src/visualizations/line\_multi.js](https://codecov.io/gh/apache/incubator-superset/pull/5189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9saW5lX211bHRpLmpz) | | |
| [superset/assets/src/components/Loading.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0xvYWRpbmcuanN4) | | |
| [superset/assets/src/explore/visTypes.js](https://codecov.io/gh/apache/incubator-superset/pull/5189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL3Zpc1R5cGVzLmpz) | | |
| [superset/assets/src/components/CachedLabel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0NhY2hlZExhYmVsLmpzeA==) | | |
| ... and [213 more](https://codecov.io/gh/apache/incubator-superset/pull/5189/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5189?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5189?src=pr&el=footer). Last update [a109543...85eab86](https://codecov.io/gh/apache/incubator-superset/pull/5189?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org