You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/01/06 15:44:14 UTC
[GitHub] [apisix-ingress-controller] gxthrj opened a new pull request #157: feat: add resync period for each resource
gxthrj opened a new pull request #157:
URL: https://github.com/apache/apisix-ingress-controller/pull/157
Fix: #137
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #157: feat: add resync period for each resource
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #157:
URL: https://github.com/apache/apisix-ingress-controller/pull/157#discussion_r553053773
##########
File path: cmd/ingress/ingress.go
##########
@@ -122,7 +122,7 @@ the apisix cluster and others are created`,
kubeClientSet := kube.GetKubeClient()
apisixClientset := kube.GetApisixClient()
- sharedInformerFactory := api6Informers.NewSharedInformerFactory(apisixClientset, 0)
+ sharedInformerFactory := api6Informers.NewSharedInformerFactory(apisixClientset, 6.*time.Hour)
Review comment:
We should use the resync_interval option here rather than hardcoding.
##########
File path: pkg/ingress/controller/apisix_route.go
##########
@@ -63,12 +63,12 @@ func BuildApisixRouteController(
apisixRouteSynced: api6RouteInformer.Informer().HasSynced,
workqueue: workqueue.NewNamedRateLimitingQueue(workqueue.NewItemFastSlowRateLimiter(1*time.Second, 60*time.Second, 5), "ApisixRoutes"),
}
- api6RouteInformer.Informer().AddEventHandler(
+ api6RouteInformer.Informer().AddEventHandlerWithResyncPeriod(
cache.ResourceEventHandlerFuncs{
AddFunc: controller.addFunc,
UpdateFunc: controller.updateFunc,
DeleteFunc: controller.deleteFunc,
- })
+ }, 30.*time.Minute)
Review comment:
Ditto.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #157: feat: add resync period for each resource
Posted by GitBox <gi...@apache.org>.
gxthrj commented on pull request #157:
URL: https://github.com/apache/apisix-ingress-controller/pull/157#issuecomment-756040769
Close this pr, have been commit in #155
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj closed pull request #157: feat: add resync period for each resource
Posted by GitBox <gi...@apache.org>.
gxthrj closed pull request #157:
URL: https://github.com/apache/apisix-ingress-controller/pull/157
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org