[GitHub] [spark] vanzin commented on issue #23843: [SPARK-26938][CORE]fill taskMetrics to SparkListenerTaskEnd Event even though task is failed

[GitBox <gi...@apache.org>]

vanzin commented on issue #23843: [SPARK-26938][CORE]fill taskMetrics to SparkListenerTaskEnd Event even though task is failed
URL: https://github.com/apache/spark/pull/23843#issuecomment-473457621
 
 
   I'm not sure I follow what you're trying to do.
   
   If you're trying to keep the previous task metric updates when the task end event doesn't have metrics (e.g. because the executor died, like in the example you have in the bug), then this is the wrong fix. In that case you should be fixing things in `AppStatusListener`, instead of reading back data created by that listener.
   
   The listener is fed data from this code, not the other way around.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org