You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by nickva <gi...@git.apache.org> on 2015/10/13 22:00:07 UTC
[GitHub] couchdb-couch pull request: Stabilize couch_task_status_tests:run_...
GitHub user nickva opened a pull request:
https://github.com/apache/couchdb-couch/pull/119
Stabilize couch_task_status_tests:run_multiple_tasks/0 test.
Previously, at the end of the test, it kills each status process
with call(Pid1, done), then immediately calls couch_task_status:all().
This caused a race between couch_task_status receiving the 'all'
call and the 'DOWN' message (from monitoring test processes). If
'DOWN' message came before 'all', test passed. If it came
after, it failed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloudant/couchdb-couch 2848-stabilize-couch-task-test
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-couch/pull/119.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #119
----
commit 26a3edba56ad096c59fa140a0102f4280742e91f
Author: Nick Vatamaniuc <va...@gmail.com>
Date: 2015-10-13T19:54:37Z
Stabilize couch_task_status_tests:run_multiple_tasks/0 test.
Previously, at the end of the test, it kills each status process
with call(Pid1, done), then immediately calls couch_task_status:all().
This caused a race between couch_task_status receiving the 'all'
call and the 'DOWN' message (from monitoring test processes). If
'DOWN' message came before 'all', test passed. If it came
after, it failed.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Stabilize couch_task_status_tests:run_...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch/pull/119#issuecomment-147842149
Can we instead of sleep, add start the monitor for Pid on call done and also hang there for some time till DOWN? Should be more generic solution which is not limited by 100ms.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Stabilize couch_task_status_tests:run_...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch/pull/119#issuecomment-147877228
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Stabilize couch_task_status_tests:run_...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-couch/pull/119
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---