You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Bruce Schuchardt <bs...@pivotal.io> on 2015/08/21 22:28:22 UTC

Review Request 37691: GEODE-77 adding unit tests for JGroupsMessenger

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37691/
-----------------------------------------------------------

Review request for geode, anilkumar gingade, Hitesh Khamesra, Jason Huynh, Jianxia Chen, Lynn Gallinat, and Qihong Chen.


Repository: geode


Description
-------

New unit tests to ensure that messages are routed to the correct MessageHandlers and that message fragmentation is working.  The test inserts an InterceptUDP protocol into the JGroups stack so we can push messages through JGroups without network communications, and so we can observe what messages are being sent by JGroups.


Diffs
-----

  gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/InterceptUDP.java PRE-CREATION 
  gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessengerJUnitTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/37691/diff/


Testing
-------


Thanks,

Bruce Schuchardt


Re: Review Request 37691: GEODE-77 adding unit tests for JGroupsMessenger

Posted by Bruce Schuchardt <bs...@pivotal.io>.

> On Aug. 21, 2015, 8:52 p.m., Jason Huynh wrote:
> > gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessengerJUnitTest.java, line 86
> > <https://reviews.apache.org/r/37691/diff/1/?file=1047825#file1047825line86>
> >
> >     Would it be possible to change this to dynamically get the class/path?  That way when the package renaming comes in, we won't have to change the class.

I'll change this to
    jgroupsConfig = jgroupsConfig.substring(0, insertIdx) +
        "<"+InterceptUDP.class.getName()+"/>" +
        jgroupsConfig.substring(insertIdx);


- Bruce


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37691/#review96083
-----------------------------------------------------------


On Aug. 21, 2015, 8:28 p.m., Bruce Schuchardt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37691/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2015, 8:28 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Hitesh Khamesra, Jason Huynh, Jianxia Chen, Lynn Gallinat, and Qihong Chen.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> New unit tests to ensure that messages are routed to the correct MessageHandlers and that message fragmentation is working.  The test inserts an InterceptUDP protocol into the JGroups stack so we can push messages through JGroups without network communications, and so we can observe what messages are being sent by JGroups.
> 
> 
> Diffs
> -----
> 
>   gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/InterceptUDP.java PRE-CREATION 
>   gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessengerJUnitTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37691/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>


Re: Review Request 37691: GEODE-77 adding unit tests for JGroupsMessenger

Posted by Jason Huynh <hu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37691/#review96083
-----------------------------------------------------------



gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessengerJUnitTest.java (line 86)
<https://reviews.apache.org/r/37691/#comment151288>

    Would it be possible to change this to dynamically get the class/path?  That way when the package renaming comes in, we won't have to change the class.


- Jason Huynh


On Aug. 21, 2015, 8:28 p.m., Bruce Schuchardt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37691/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2015, 8:28 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Hitesh Khamesra, Jason Huynh, Jianxia Chen, Lynn Gallinat, and Qihong Chen.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> New unit tests to ensure that messages are routed to the correct MessageHandlers and that message fragmentation is working.  The test inserts an InterceptUDP protocol into the JGroups stack so we can push messages through JGroups without network communications, and so we can observe what messages are being sent by JGroups.
> 
> 
> Diffs
> -----
> 
>   gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/InterceptUDP.java PRE-CREATION 
>   gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessengerJUnitTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37691/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>


Re: Review Request 37691: GEODE-77 adding unit tests for JGroupsMessenger

Posted by Jason Huynh <hu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37691/#review96085
-----------------------------------------------------------

Ship it!


Ship It!

- Jason Huynh


On Aug. 21, 2015, 8:28 p.m., Bruce Schuchardt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37691/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2015, 8:28 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Hitesh Khamesra, Jason Huynh, Jianxia Chen, Lynn Gallinat, and Qihong Chen.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> New unit tests to ensure that messages are routed to the correct MessageHandlers and that message fragmentation is working.  The test inserts an InterceptUDP protocol into the JGroups stack so we can push messages through JGroups without network communications, and so we can observe what messages are being sent by JGroups.
> 
> 
> Diffs
> -----
> 
>   gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/InterceptUDP.java PRE-CREATION 
>   gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessengerJUnitTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37691/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>