You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/05/23 20:36:19 UTC

[GitHub] [cordova-plugin-camera] PieterVanPoyer opened a new pull request #731: Bugfix issue 711 heif format

PieterVanPoyer opened a new pull request #731:
URL: https://github.com/apache/cordova-plugin-camera/pull/731


   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   
   Android
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   
   Fixes #711 
   
   ### Description
   <!-- Describe your changes in detail -->
   
   When a .heic image is selected from a gallery it is converted to a .jpeg or .png image.
   
   In the webview part the returned image can be shown in an image tag or it can be send to the server.
   
   Some extra code cleanup is done too.
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   
   Testing in the emulator with next repo: https://github.com/PieterVanPoyer/cordova-camera-plugin-testing-app/tree/features/issue-711-heif-format 
   
   ### Checklist
   
   - [ ] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [ ] I've updated the documentation if necessary
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-plugin-camera] PieterVanPoyer commented on pull request #731: Bugfix issue 711 heif format

Posted by GitBox <gi...@apache.org>.
PieterVanPoyer commented on pull request #731:
URL: https://github.com/apache/cordova-plugin-camera/pull/731#issuecomment-849103134


   There is a small discussion in the issue log. (see https://github.com/apache/cordova-plugin-camera/issues/711#issuecomment-846812829 )
   Maybe more formats should be converted to the encodingType of the options.
   
   But I do not like to make such a change right away. Such a change needs a little bit more discussion I think.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-plugin-camera] PieterVanPoyer merged pull request #731: Bugfix issue 711 heic format

Posted by GitBox <gi...@apache.org>.
PieterVanPoyer merged pull request #731:
URL: https://github.com/apache/cordova-plugin-camera/pull/731


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org