Re: [PR] JAMES-4133 Add support for unicode adddresses as defined in RFC6532. [james-project]

["arnt (via GitHub)" <gi...@apache.org>]

arnt commented on code in PR #2728:
URL: https://github.com/apache/james-project/pull/2728#discussion_r3959494181


##########
protocols/smtp/src/main/java/org/apache/james/protocols/smtp/core/RcptCmdHandler.java:
##########
@@ -195,6 +221,15 @@ protected Response doFilterChecks(SMTPSession session, String command,
         return null;
     }
 
+    private static boolean containsNonAscii(String s) {
+        for (int i = 0; i < s.length(); i++) {
+            if (s.charAt(i) > 0x7F) {
+                return true;
+            }
+        }
+        return false;
+    }

Review Comment:
   I didn't see a natural place (other than java.lang.String). But you picked one, which is good.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org