You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Vincent P (JIRA)" <ji...@apache.org> on 2019/01/24 09:27:00 UTC
[jira] [Created] (HBASE-21769) Support named Connection
Vincent P created HBASE-21769:
---------------------------------
Summary: Support named Connection
Key: HBASE-21769
URL: https://issues.apache.org/jira/browse/HBASE-21769
Project: HBase
Issue Type: Improvement
Components: Client
Affects Versions: 1.4.0, 1.2.0
Reporter: Vincent P
Metrics as taken from {{MetricsConnection}} are grouped by connection-id which is defined using {{hashCode}} in {{HConnectionImplementation}}.
This approach has several drawbacks when this connection-id matters (multi-cluster), which leads to wrong aggregates :
* There is a remote yet uncontrollable possibility of collision
* connection-id is almost certain to change on JVM restart
* connection-id doesn't match with other client machines.
While the {{Connection}} implementation is customizable ("hbase.client.connection.impl"), the original {{HConnectionImplementation}} is not public, and this default behaviour (toString based on hashCode) doesn't seem particularly desirable.
I am proposing to change the allow overriding default {{toString()}} implementation with a configuration-based value.
Side-effects (for users of this feature only) will include a change of name in connection threads, too (which seems desirable to me).
As the patch is trivial, let me omit it until this issue has been reviewed by a committer project member.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)