[GitHub] [inlong] liaorui commented on a diff in pull request #7394: [INLONG-7391][Sort] Support CSV format and dirty data collecting for StarRocks connector all db migrating

["liaorui (via GitHub)" <gi...@apache.org>]

liaorui commented on code in PR #7394:
URL: https://github.com/apache/inlong/pull/7394#discussion_r1113763610


##########
inlong-sort/sort-connectors/base/src/test/java/org/apache/inlong/sort/base/dirty/RegexReplaceTest.java:
##########
@@ -32,7 +32,7 @@ public void testRegexReplacement() throws IOException {
         identifier[0] = "yizhouyang";
         identifier[1] = "table2";
         String pattern = "${database}-${table}-${DIRTY_MESSAGE}";
-        String answer = DirtySinkHelper.regexReplace(pattern, DirtyType.BATCH_LOAD_ERROR, "mock message", identifier);
+        String answer = DirtySinkHelper.regexReplace(pattern, DirtyType.BATCH_LOAD_ERROR, "mock message");

Review Comment:
   Fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org