[GitHub] [druid] capistrant commented on a change in pull request #10724: Coordinator Dynamic Config changes to ease upgrading with new config value

[GitBox <gi...@apache.org>]

capistrant commented on a change in pull request #10724:
URL: https://github.com/apache/druid/pull/10724#discussion_r552218228



##########
File path: server/src/main/java/org/apache/druid/server/coordinator/CoordinatorDynamicConfig.java
##########
@@ -126,6 +129,15 @@ public CoordinatorDynamicConfig(
     this.mergeSegmentsLimit = mergeSegmentsLimit;
     this.maxSegmentsToMove = maxSegmentsToMove;
 
+    if (percentOfSegmentsToConsiderPerMove == null) {
+      log.warn("percentOfSegmentsToConsiderPerMove was null! This is likely because your metastore does not "

Review comment:
       ya, I guess this is fine as a debug. It will actually automatically get set to the default (or the user specified value) the next time a user submits a new dynamic config since that code path uses builder which will populate missing values. will update now




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org