You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/05 22:35:01 UTC
[GitHub] [superset] lilykuang opened a new pull request #12977: fix(alert/report): bulk select mode should be deactivated
lilykuang opened a new pull request #12977:
URL: https://github.com/apache/superset/pull/12977
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
- bulk mode should be deactivated when switch between report and alert
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
After:
https://www.loom.com/share/1f3ed9f60e834e59b531f0e070d0d730
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12977: fix(alert/report): bulk select mode should be deactivated
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12977:
URL: https://github.com/apache/superset/pull/12977#issuecomment-774329996
# [Codecov](https://codecov.io/gh/apache/superset/pull/12977?src=pr&el=h1) Report
> Merging [#12977](https://codecov.io/gh/apache/superset/pull/12977?src=pr&el=desc) (a84b568) into [master](https://codecov.io/gh/apache/superset/commit/76bcc446f0261ad104c4c981040f643bc9a8c94d?el=desc) (76bcc44) will **increase** coverage by `22.64%`.
> The diff coverage is `75.00%`.
[](https://codecov.io/gh/apache/superset/pull/12977?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12977 +/- ##
===========================================
+ Coverage 49.09% 71.73% +22.64%
===========================================
Files 480 558 +78
Lines 17315 22278 +4963
Branches 4485 6006 +1521
===========================================
+ Hits 8501 15982 +7481
+ Misses 8814 6144 -2670
- Partials 0 152 +152
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `52.96% <0.00%> (+3.87%)` | :arrow_up: |
| javascript | `61.78% <75.00%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12977?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...perset-frontend/src/views/CRUD/alert/AlertList.tsx](https://codecov.io/gh/apache/superset/pull/12977/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvQWxlcnRMaXN0LnRzeA==) | `76.33% <75.00%> (+73.47%)` | :arrow_up: |
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/12977/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `18.18% <0.00%> (-81.82%)` | :arrow_down: |
| [superset-frontend/src/views/index.tsx](https://codecov.io/gh/apache/superset/pull/12977/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2luZGV4LnRzeA==) | `25.00% <0.00%> (-75.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.tsx](https://codecov.io/gh/apache/superset/pull/12977/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC50c3g=) | `25.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...ntend/src/filters/components/Range/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/12977/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9SYW5nZS9jb250cm9sUGFuZWwudHM=) | `25.00% <0.00%> (-75.00%)` | :arrow_down: |
| [superset-frontend/src/views/App.tsx](https://codecov.io/gh/apache/superset/pull/12977/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0FwcC50c3g=) | `25.58% <0.00%> (-74.42%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/index.ts](https://codecov.io/gh/apache/superset/pull/12977/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvaW5kZXgudHM=) | `40.00% <0.00%> (-60.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupPlugins.ts](https://codecov.io/gh/apache/superset/pull/12977/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2lucy50cw==) | `44.44% <0.00%> (-55.56%)` | :arrow_down: |
| [superset-frontend/src/setup/setupPluginsExtra.ts](https://codecov.io/gh/apache/superset/pull/12977/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2luc0V4dHJhLnRz) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...rset-frontend/src/setup/setupErrorMessagesExtra.ts](https://codecov.io/gh/apache/superset/pull/12977/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRXJyb3JNZXNzYWdlc0V4dHJhLnRz) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| ... and [440 more](https://codecov.io/gh/apache/superset/pull/12977/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12977?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12977?src=pr&el=footer). Last update [76bcc44...a84b568](https://codecov.io/gh/apache/superset/pull/12977?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io commented on pull request #12977: fix(alert/report): bulk select mode should be deactivated
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12977:
URL: https://github.com/apache/superset/pull/12977#issuecomment-774329996
# [Codecov](https://codecov.io/gh/apache/superset/pull/12977?src=pr&el=h1) Report
> Merging [#12977](https://codecov.io/gh/apache/superset/pull/12977?src=pr&el=desc) (a84b568) into [master](https://codecov.io/gh/apache/superset/commit/76bcc446f0261ad104c4c981040f643bc9a8c94d?el=desc) (76bcc44) will **increase** coverage by `12.67%`.
> The diff coverage is `75.00%`.
[](https://codecov.io/gh/apache/superset/pull/12977?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12977 +/- ##
===========================================
+ Coverage 49.09% 61.77% +12.67%
===========================================
Files 480 537 +57
Lines 17315 20130 +2815
Branches 4485 5262 +777
===========================================
+ Hits 8501 12435 +3934
+ Misses 8814 7482 -1332
- Partials 0 213 +213
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `61.77% <75.00%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12977?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...perset-frontend/src/views/CRUD/alert/AlertList.tsx](https://codecov.io/gh/apache/superset/pull/12977/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvQWxlcnRMaXN0LnRzeA==) | `76.33% <75.00%> (+73.47%)` | :arrow_up: |
| [superset-frontend/src/views/App.tsx](https://codecov.io/gh/apache/superset/pull/12977/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0FwcC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/12977/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/views/menu.tsx](https://codecov.io/gh/apache/superset/pull/12977/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL21lbnUudHN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/superset/pull/12977/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/views/index.tsx](https://codecov.io/gh/apache/superset/pull/12977/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2luZGV4LnRzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.tsx](https://codecov.io/gh/apache/superset/pull/12977/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/superset/pull/12977/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupPlugins.ts](https://codecov.io/gh/apache/superset/pull/12977/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2lucy50cw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupFormatters.ts](https://codecov.io/gh/apache/superset/pull/12977/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy50cw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [455 more](https://codecov.io/gh/apache/superset/pull/12977/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12977?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12977?src=pr&el=footer). Last update [76bcc44...a84b568](https://codecov.io/gh/apache/superset/pull/12977?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] willbarrett commented on pull request #12977: fix(alert/report): bulk select mode should be deactivated
Posted by GitBox <gi...@apache.org>.
willbarrett commented on pull request #12977:
URL: https://github.com/apache/superset/pull/12977#issuecomment-778500900
nit: can we add a test?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12977: fix(alert/report): bulk select mode should be deactivated
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12977:
URL: https://github.com/apache/superset/pull/12977#issuecomment-774329996
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] willbarrett closed pull request #12977: fix(alert/report): bulk select mode should be deactivated
Posted by GitBox <gi...@apache.org>.
willbarrett closed pull request #12977:
URL: https://github.com/apache/superset/pull/12977
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] willbarrett merged pull request #12977: fix(alert/report): bulk select mode should be deactivated
Posted by GitBox <gi...@apache.org>.
willbarrett merged pull request #12977:
URL: https://github.com/apache/superset/pull/12977
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12977: fix(alert/report): bulk select mode should be deactivated
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12977:
URL: https://github.com/apache/superset/pull/12977#issuecomment-774329996
# [Codecov](https://codecov.io/gh/apache/superset/pull/12977?src=pr&el=h1) Report
> Merging [#12977](https://codecov.io/gh/apache/superset/pull/12977?src=pr&el=desc) (a84b568) into [master](https://codecov.io/gh/apache/superset/commit/76bcc446f0261ad104c4c981040f643bc9a8c94d?el=desc) (76bcc44) will **increase** coverage by `23.70%`.
> The diff coverage is `75.00%`.
[](https://codecov.io/gh/apache/superset/pull/12977?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12977 +/- ##
===========================================
+ Coverage 49.09% 72.79% +23.70%
===========================================
Files 480 537 +57
Lines 17315 20152 +2837
Branches 4485 5262 +777
===========================================
+ Hits 8501 14670 +6169
+ Misses 8814 5357 -3457
- Partials 0 125 +125
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `52.96% <0.00%> (+3.87%)` | :arrow_up: |
| javascript | `61.77% <75.00%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12977?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...perset-frontend/src/views/CRUD/alert/AlertList.tsx](https://codecov.io/gh/apache/superset/pull/12977/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvQWxlcnRMaXN0LnRzeA==) | `76.33% <75.00%> (+73.47%)` | :arrow_up: |
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/12977/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `18.18% <0.00%> (-81.82%)` | :arrow_down: |
| [superset-frontend/src/views/index.tsx](https://codecov.io/gh/apache/superset/pull/12977/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2luZGV4LnRzeA==) | `25.00% <0.00%> (-75.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.tsx](https://codecov.io/gh/apache/superset/pull/12977/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC50c3g=) | `25.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...ntend/src/filters/components/Range/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/12977/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9SYW5nZS9jb250cm9sUGFuZWwudHM=) | `25.00% <0.00%> (-75.00%)` | :arrow_down: |
| [superset-frontend/src/views/App.tsx](https://codecov.io/gh/apache/superset/pull/12977/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0FwcC50c3g=) | `25.58% <0.00%> (-74.42%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/index.ts](https://codecov.io/gh/apache/superset/pull/12977/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvaW5kZXgudHM=) | `40.00% <0.00%> (-60.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupPlugins.ts](https://codecov.io/gh/apache/superset/pull/12977/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2lucy50cw==) | `44.44% <0.00%> (-55.56%)` | :arrow_down: |
| [superset-frontend/src/setup/setupPluginsExtra.ts](https://codecov.io/gh/apache/superset/pull/12977/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2luc0V4dHJhLnRz) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...rset-frontend/src/setup/setupErrorMessagesExtra.ts](https://codecov.io/gh/apache/superset/pull/12977/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRXJyb3JNZXNzYWdlc0V4dHJhLnRz) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| ... and [413 more](https://codecov.io/gh/apache/superset/pull/12977/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12977?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12977?src=pr&el=footer). Last update [76bcc44...a84b568](https://codecov.io/gh/apache/superset/pull/12977?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12977: fix(alert/report): bulk select mode should be deactivated
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12977:
URL: https://github.com/apache/superset/pull/12977#issuecomment-774329996
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org