You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/12 04:28:13 UTC
[GitHub] [flink] Aitozi opened a new pull request, #19938: [FLINK-27737] Remove legacy support for unfenced executor in FencedRpcEndpoint
Aitozi opened a new pull request, #19938:
URL: https://github.com/apache/flink/pull/19938
## What is the purpose of the change
This PR is mean to clean up all the un-fenced executor support in the rpcEndpoint.
## Brief change log
- Make the FencedRpcEndpoint's `fencingToken` `@NonNull` and `final`
- Remove the `Unfencedmessage` and `UnfencedMainThreadExecutor`
- Remove the `PermanentlyFencedRpcEndpoint` since the FencedRpcEndpoint's token is unchanged now
- Remove the unnecessary tests.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Aitozi commented on pull request #19938: [FLINK-27737] Remove legacy support for unfenced executor in FencedRpcEndpoint
Posted by GitBox <gi...@apache.org>.
Aitozi commented on PR #19938:
URL: https://github.com/apache/flink/pull/19938#issuecomment-1153076854
cc @xintongsong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Aitozi commented on a diff in pull request #19938: [FLINK-27737] Remove legacy support for unfenced executor in FencedRpcEndpoint
Posted by GitBox <gi...@apache.org>.
Aitozi commented on code in PR #19938:
URL: https://github.com/apache/flink/pull/19938#discussion_r895309493
##########
flink-rpc/flink-rpc-core/src/main/java/org/apache/flink/runtime/rpc/FencedRpcEndpoint.java:
##########
@@ -65,29 +54,14 @@ protected FencedRpcEndpoint(
mainThreadExecutable, this::validateRunsInMainThread, endpointId));
}
- protected FencedRpcEndpoint(RpcService rpcService, @Nullable F fencingToken) {
+ protected FencedRpcEndpoint(RpcService rpcService, @Nonnull F fencingToken) {
Review Comment:
Get, will remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xintongsong closed pull request #19938: [FLINK-27737] Remove legacy support for unfenced executor in FencedRpcEndpoint
Posted by GitBox <gi...@apache.org>.
xintongsong closed pull request #19938: [FLINK-27737] Remove legacy support for unfenced executor in FencedRpcEndpoint
URL: https://github.com/apache/flink/pull/19938
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #19938: [FLINK-27737] Remove legacy support for unfenced executor in FencedRpcEndpoint
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19938:
URL: https://github.com/apache/flink/pull/19938#issuecomment-1153068629
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "242b236162ecb30f17e358a6df130308e507dbf6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "242b236162ecb30f17e358a6df130308e507dbf6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 242b236162ecb30f17e358a6df130308e507dbf6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xintongsong commented on a diff in pull request #19938: [FLINK-27737] Remove legacy support for unfenced executor in FencedRpcEndpoint
Posted by GitBox <gi...@apache.org>.
xintongsong commented on code in PR #19938:
URL: https://github.com/apache/flink/pull/19938#discussion_r895293404
##########
flink-rpc/flink-rpc-core/src/main/java/org/apache/flink/runtime/rpc/FencedRpcEndpoint.java:
##########
@@ -40,23 +35,17 @@
*/
public abstract class FencedRpcEndpoint<F extends Serializable> extends RpcEndpoint {
- private final UnfencedMainThreadExecutor unfencedMainThreadExecutor;
- private volatile F fencingToken;
+ private final F fencingToken;
private volatile MainThreadExecutor fencedMainThreadExecutor;
Review Comment:
It seems we no longer need this `fencedMainThreadExecutor`, as now it is no different from `RpcEndpoint#mainThreadExecutor`.
##########
flink-rpc/flink-rpc-core/src/main/java/org/apache/flink/runtime/rpc/FencedRpcEndpoint.java:
##########
@@ -65,29 +54,14 @@ protected FencedRpcEndpoint(
mainThreadExecutable, this::validateRunsInMainThread, endpointId));
}
- protected FencedRpcEndpoint(RpcService rpcService, @Nullable F fencingToken) {
+ protected FencedRpcEndpoint(RpcService rpcService, @Nonnull F fencingToken) {
Review Comment:
We don't usually use `@Nonnull`, as anything not `@Nullable` is expected non-null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Aitozi commented on a diff in pull request #19938: [FLINK-27737] Remove legacy support for unfenced executor in FencedRpcEndpoint
Posted by GitBox <gi...@apache.org>.
Aitozi commented on code in PR #19938:
URL: https://github.com/apache/flink/pull/19938#discussion_r895315349
##########
flink-rpc/flink-rpc-core/src/main/java/org/apache/flink/runtime/rpc/FencedRpcEndpoint.java:
##########
@@ -40,23 +35,17 @@
*/
public abstract class FencedRpcEndpoint<F extends Serializable> extends RpcEndpoint {
- private final UnfencedMainThreadExecutor unfencedMainThreadExecutor;
- private volatile F fencingToken;
+ private final F fencingToken;
private volatile MainThreadExecutor fencedMainThreadExecutor;
Review Comment:
Nice suggestion, will remove it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org