You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2019/12/02 20:35:11 UTC

[GitHub] [helix] jiajunwang commented on a change in pull request #636: Simply and enhance the RebalanceLatencyGauge so it can be used in multi-threads.

jiajunwang commented on a change in pull request #636: Simply and enhance the RebalanceLatencyGauge so it can be used in multi-threads.
URL: https://github.com/apache/helix/pull/636#discussion_r352815049
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/monitoring/metrics/implementation/RebalanceLatencyGauge.java
 ##########
 @@ -30,6 +31,7 @@
   private static final Logger LOG = LoggerFactory.getLogger(RebalanceLatencyGauge.class);
   private static final long VALUE_NOT_SET = -1;
   private long _lastEmittedMetricValue = VALUE_NOT_SET;
+  private final ThreadLocal<Long> _startTime;
 
 Review comment:
   Sorry I didn't see those comments. But it's a good suggestion. Let me add it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org