[GitHub] [directory-kerby] wjc920 commented on pull request #114: [DIRKRB-762] The AS request appears with an NPE when preauth_required is set to false

[GitBox <gi...@apache.org>]

wjc920 commented on PR #114:
URL: https://github.com/apache/directory-kerby/pull/114#issuecomment-1359548573

   > I think this change isn't quite right, as if isPreauthRequired() then it will never call the else statement. Instead it should be something like:
   > 
   > ```
   > if (preAuthData == null || preAuthData.isEmpty())) {
   >     if (isPreauthRequred()) {
   >         LOG.info("The preauth data is empty.");
   >                 KrbError krbError = makePreAuthenticationError(kdcContext, request,
   >                         KrbErrorCode.KDC_ERR_PREAUTH_REQUIRED, false);
   >                 throw new KdcRecoverableException(krbError);
   >     }
   > } else {
   >     ...
   > ```
   > 
   > If you make this change does it work properly?
   
   I modified the content of the PR by force push.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org