You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "davidcavazos (via GitHub)" <gi...@apache.org> on 2023/08/09 22:23:25 UTC
[GitHub] [beam] davidcavazos opened a new pull request, #27942: Create py.typed for use with mypy
davidcavazos opened a new pull request, #27942:
URL: https://github.com/apache/beam/pull/27942
Addresses: #27906
Create type stubs file to allow `mypy` and other type checkers to run on user's pipelines.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [x] Update `CHANGES.md` with noteworthy changes.
- [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #27942: Create py.typed for use with mypy
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #27942:
URL: https://github.com/apache/beam/pull/27942#issuecomment-1694409775
If you pull in the changes from master (sync your fork then `git pull origin master`) you should be able to add it to the features/improvements section in the 2.51 section
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #27942: Create py.typed for use with mypy
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27942:
URL: https://github.com/apache/beam/pull/27942#issuecomment-1683831130
Reminder, please take a look at this pr: @damccorm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] davidcavazos commented on pull request #27942: Create py.typed for use with mypy
Posted by "davidcavazos (via GitHub)" <gi...@apache.org>.
davidcavazos commented on PR #27942:
URL: https://github.com/apache/beam/pull/27942#issuecomment-1726659828
Updated CHANGES for 2.51
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #27942: Create py.typed for use with mypy
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27942:
URL: https://github.com/apache/beam/pull/27942#issuecomment-1704289504
Reminder, please take a look at this pr: @damccorm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] jrmccluskey commented on a diff in pull request #27942: Create py.typed for use with mypy
Posted by "jrmccluskey (via GitHub)" <gi...@apache.org>.
jrmccluskey commented on code in PR #27942:
URL: https://github.com/apache/beam/pull/27942#discussion_r1290274665
##########
sdks/python/apache_beam/py.typed:
##########
@@ -0,0 +1,2 @@
+# Marker file for PEP 561.
Review Comment:
```suggestion
#
# Licensed to the Apache Software Foundation (ASF) under one or more
# contributor license agreements. See the NOTICE file distributed with
# this work for additional information regarding copyright ownership.
# The ASF licenses this file to You under the Apache License, Version 2.0
# (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
# Marker file for PEP 561.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #27942: Create py.typed for use with mypy
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on PR #27942:
URL: https://github.com/apache/beam/pull/27942#issuecomment-1673392332
Thanks, @davidcavazos . We need to include Apache licences in all files to pass RAT check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #27942: Create py.typed for use with mypy
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27942:
URL: https://github.com/apache/beam/pull/27942#issuecomment-1672318613
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #27942: Create py.typed for use with mypy
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #27942:
URL: https://github.com/apache/beam/pull/27942#discussion_r1306094781
##########
CHANGES.md:
##########
@@ -84,6 +84,7 @@
* Transform service controller container.
* Spark3 job server container.
* Added support for batched writes to AWS SQS for improved throughput (Java, AWS 2).([#21429](https://github.com/apache/beam/issues/21429))
+* Added support to run `mypy` on user pipelines ([#27906](https://github.com/apache/beam/issues/27906))
Review Comment:
If you pull in the changes from the master branch there is a 2.51 section - https://github.com/apache/beam/blob/master/CHANGES.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn merged pull request #27942: Create py.typed for use with mypy
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn merged PR #27942:
URL: https://github.com/apache/beam/pull/27942
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] davidcavazos commented on a diff in pull request #27942: Create py.typed for use with mypy
Posted by "davidcavazos (via GitHub)" <gi...@apache.org>.
davidcavazos commented on code in PR #27942:
URL: https://github.com/apache/beam/pull/27942#discussion_r1306093819
##########
CHANGES.md:
##########
@@ -84,6 +84,7 @@
* Transform service controller container.
* Spark3 job server container.
* Added support for batched writes to AWS SQS for improved throughput (Java, AWS 2).([#21429](https://github.com/apache/beam/issues/21429))
+* Added support to run `mypy` on user pipelines ([#27906](https://github.com/apache/beam/issues/27906))
Review Comment:
It's currently under 2.50.0 Unreleased, I don't see a 2.51 so what should we do with this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on a diff in pull request #27942: Create py.typed for use with mypy
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on code in PR #27942:
URL: https://github.com/apache/beam/pull/27942#discussion_r1290762518
##########
CHANGES.md:
##########
@@ -84,6 +84,7 @@
* Transform service controller container.
* Spark3 job server container.
* Added support for batched writes to AWS SQS for improved throughput (Java, AWS 2).([#21429](https://github.com/apache/beam/issues/21429))
+* Added support to run `mypy` on user pipelines ([#27906](https://github.com/apache/beam/issues/27906))
Review Comment:
this change didn't make a release cut unfortunately.
##########
CHANGES.md:
##########
@@ -84,6 +84,7 @@
* Transform service controller container.
* Spark3 job server container.
* Added support for batched writes to AWS SQS for improved throughput (Java, AWS 2).([#21429](https://github.com/apache/beam/issues/21429))
+* Added support to run `mypy` on user pipelines ([#27906](https://github.com/apache/beam/issues/27906))
Review Comment:
this change didn't make the release cut unfortunately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] davidcavazos commented on pull request #27942: Create py.typed for use with mypy
Posted by "davidcavazos (via GitHub)" <gi...@apache.org>.
davidcavazos commented on PR #27942:
URL: https://github.com/apache/beam/pull/27942#issuecomment-1693862958
The only open issue is where to announce the change in CHANGES.md, but I don't know where we should place it. Can someone point me in the right direction?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #27942: Create py.typed for use with mypy
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #27942:
URL: https://github.com/apache/beam/pull/27942#issuecomment-1672274973
## [Codecov](https://app.codecov.io/gh/apache/beam/pull/27942?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#27942](https://app.codecov.io/gh/apache/beam/pull/27942?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (b3bc0c5) into [master](https://app.codecov.io/gh/apache/beam/commit/f07fe408661f6771baccd8c12a44c1daf48b1315?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f07fe40) will **not change** coverage.
> Report is 2 commits behind head on master.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #27942 +/- ##
=======================================
Coverage 70.57% 70.57%
=======================================
Files 857 857
Lines 103947 103947
=======================================
Hits 73364 73364
Misses 29021 29021
Partials 1562 1562
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org