[GitHub] [iceberg] aokolnychyi commented on a change in pull request #2547: Hive: add table level JVM lock on HiveCatalog commit operation

[GitBox <gi...@apache.org>]

aokolnychyi commented on a change in pull request #2547:
URL: https://github.com/apache/iceberg/pull/2547#discussion_r627915043



##########
File path: hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java
##########
@@ -191,6 +209,10 @@ protected void doCommit(TableMetadata base, TableMetadata metadata) {
     CommitStatus commitStatus = CommitStatus.FAILURE;
     boolean updateHiveTable = false;
     Optional<Long> lockId = Optional.empty();
+    // getting a process-level lock per table to avoid concurrent commit attempts to the same table from the same
+    // JVM process, which would result in unnecessary and costly HMS lock acquisition requests
+    ReentrantLock tableLevelMutex = commitLockCache.get(fullName, t -> new ReentrantLock(true));

Review comment:
       This seems safe even though one application can interact with multiple metastores as full name includes the catalog name.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org