You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2020/04/22 11:19:27 UTC
[GitHub] [cassandra] smiklosovic opened a new pull request #555: CASSANDRA-15748 - injecting of parameters into IAuditLogger implementation
smiklosovic opened a new pull request #555:
URL: https://github.com/apache/cassandra/pull/555
@krummas considered done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] smiklosovic commented on a change in pull request #555: CASSANDRA-15748 - injecting of parameters into IAuditLogger implementation
Posted by GitBox <gi...@apache.org>.
smiklosovic commented on a change in pull request #555:
URL: https://github.com/apache/cassandra/pull/555#discussion_r421450464
##########
File path: src/java/org/apache/cassandra/audit/BinAuditLogger.java
##########
@@ -40,7 +41,7 @@
private volatile BinLog binLog;
- public BinAuditLogger()
+ public BinAuditLogger(Map<String, String> params)
Review comment:
@krummas please check second commit if you wish to go with that option. "other cases" I meant e.g. `SeedProvider`, its constructor accepts this map, even empty ... `ICompressor` implementations have static method accepting that map and so on.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] smiklosovic closed pull request #555: CASSANDRA-15748 - injecting of parameters into IAuditLogger implementation
Posted by GitBox <gi...@apache.org>.
smiklosovic closed pull request #555:
URL: https://github.com/apache/cassandra/pull/555
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] krummas commented on a change in pull request #555: CASSANDRA-15748 - injecting of parameters into IAuditLogger implementation
Posted by GitBox <gi...@apache.org>.
krummas commented on a change in pull request #555:
URL: https://github.com/apache/cassandra/pull/555#discussion_r421462967
##########
File path: src/java/org/apache/cassandra/audit/BinAuditLogger.java
##########
@@ -40,7 +41,7 @@
private volatile BinLog binLog;
- public BinAuditLogger()
+ public BinAuditLogger(Map<String, String> params)
Review comment:
yeah looks like we do this in other places, fine to leave as is
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] krummas commented on a change in pull request #555: CASSANDRA-15748 - injecting of parameters into IAuditLogger implementation
Posted by GitBox <gi...@apache.org>.
krummas commented on a change in pull request #555:
URL: https://github.com/apache/cassandra/pull/555#discussion_r421417541
##########
File path: src/java/org/apache/cassandra/audit/BinAuditLogger.java
##########
@@ -40,7 +41,7 @@
private volatile BinLog binLog;
- public BinAuditLogger()
+ public BinAuditLogger(Map<String, String> params)
Review comment:
instead of adding this (most often) unused parameter, could we just grab the params from `DatabaseDescriptor.getAuditLoggingOptions().logger.parameters` in the constructor if we need them?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] smiklosovic commented on a change in pull request #555: CASSANDRA-15748 - injecting of parameters into IAuditLogger implementation
Posted by GitBox <gi...@apache.org>.
smiklosovic commented on a change in pull request #555:
URL: https://github.com/apache/cassandra/pull/555#discussion_r421428548
##########
File path: src/java/org/apache/cassandra/audit/BinAuditLogger.java
##########
@@ -40,7 +41,7 @@
private volatile BinLog binLog;
- public BinAuditLogger()
+ public BinAuditLogger(Map<String, String> params)
Review comment:
@krummas we indeed technically could but I am missing the point ... for other cases this is way how to do things and now we are introducing something "custom". So lets remove this parameter from all other cases it occurs? Having it inconsistent is even worse imho.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org