You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "damccorm (via GitHub)" <gi...@apache.org> on 2023/07/25 21:07:14 UTC
[GitHub] [beam] damccorm opened a new pull request, #27671: Change how we interrupt in progress runs
damccorm opened a new pull request, #27671:
URL: https://github.com/apache/beam/pull/27671
Right now, we define concurrency groups as `${{ github.workflow }} @ ${{ github.event.pull_request.head.label || github.head_ref || github.ref }}`. This means that for each workflow, if all workflows for a PR will be in a group, and all non-PR runs against the same branch will be in a group. Since each commit in a group cancels all previous runs for that group, the outcome is that all commits against master cancel all previous runs of workflows against master, often meaning that we never actually complete a run against master (or at least don't for a while).
This updates concurrency groups to be `${{ github.workflow }} @ ${{ github.event.pull_request.head.label || github.sha || github.head_ref || github.ref }}-${{ github.event.sender.login }}-${{ github.event.schedule }}`
Basically, this means for each workflow, there will be a different concurrency group:
1) Per pull request (`github.event.pull_request.head.label`)
2) Per commit not on a pull request (`github.sha`)
3) Per commit/user combo if keyed off of workflow_dispatch (`github.event.sender.login`)
4) Per commit in a scheduled workflow (`github.event.schedule`)
This will significantly increase the number of runs we're doing, but will ensure we are actually getting all the validation we need. If needed, we can up our worker pool size
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm merged pull request #27671: Change how we interrupt in progress runs
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm merged PR #27671:
URL: https://github.com/apache/beam/pull/27671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #27671: Change how we interrupt in progress runs
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #27671:
URL: https://github.com/apache/beam/pull/27671#issuecomment-1650561942
R: @Abacn @andreydevyatkin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #27671: Change how we interrupt in progress runs
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27671:
URL: https://github.com/apache/beam/pull/27671#issuecomment-1650563237
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org