You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/08/11 22:06:00 UTC

[GitHub] [beam] lukecwik commented on a change in pull request #15319: [BEAM-10212] Guard state caching with experiment

lukecwik commented on a change in pull request #15319:
URL: https://github.com/apache/beam/pull/15319#discussion_r687227353



##########
File path: runners/java-fn-execution/src/test/java/org/apache/beam/runners/fnexecution/control/RemoteExecutionTest.java
##########
@@ -535,160 +532,6 @@ public void processElement(ProcessContext context) {
     }
   }
 
-  @Test

Review comment:
       Instead of creating a new file and copying the setup logic rename setup to `launchSdkHarness(PipelineOptions options)` and have each test run that method as the first line of each test. You'll also want to drop the `@Setup` annotation.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org