You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/09/08 17:54:51 UTC

[GitHub] [cloudstack] davidjumani opened a new pull request #4311: Disallowing only space characters as a string api parameter

davidjumani opened a new pull request #4311:
URL: https://github.com/apache/cloudstack/pull/4311


   ## Description
   Disallowing only space characters as a string api parameter
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## How Has This Been Tested?
   TODO


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4311: Trimming string api parameters and disallowing only space as an api parameter value

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4311:
URL: https://github.com/apache/cloudstack/pull/4311#issuecomment-692537531


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4311: Trimming string api parameters and disallowing only space as an api parameter value

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4311:
URL: https://github.com/apache/cloudstack/pull/4311#issuecomment-692611373


   Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2012


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4311: Trimming string api parameters and disallowing only space as an api parameter value

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4311:
URL: https://github.com/apache/cloudstack/pull/4311#issuecomment-691655552


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4311: Trimming string api parameters and disallowing only space as an api parameter value

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4311:
URL: https://github.com/apache/cloudstack/pull/4311#issuecomment-692560255


   Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2010


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4311: Trimming string api parameters and disallowing only space as an api parameter value

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4311:
URL: https://github.com/apache/cloudstack/pull/4311#issuecomment-689294621


   @davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] davidjumani commented on pull request #4311: Trimming string api parameters and disallowing only space as an api parameter value

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4311:
URL: https://github.com/apache/cloudstack/pull/4311#issuecomment-693807963


   Looks like some of the smoke tests use test data containing strings with trailing spaces. Fixing them


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4311: Trimming string api parameters and disallowing only space as an api parameter value

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4311:
URL: https://github.com/apache/cloudstack/pull/4311#issuecomment-693234440


   @blueorangutan test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4311: Trimming string api parameters and disallowing only space as an api parameter value

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4311:
URL: https://github.com/apache/cloudstack/pull/4311#issuecomment-689472117


   @blueorangutan test matrix


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4311: Trimming string api parameters and disallowing only space as an api parameter value

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4311:
URL: https://github.com/apache/cloudstack/pull/4311#issuecomment-692586676


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4311: Trimming string api parameters and disallowing only space as an api parameter value

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4311:
URL: https://github.com/apache/cloudstack/pull/4311#issuecomment-689938337


   <b>Trillian test result (tid-2707)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 55139 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4311-t2707-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
   Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_extra_config_data.py
   Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
   Intermittent failure detected: /marvin/tests/smoke/test_dynamicroles.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
   Intermittent failure detected: /marvin/tests/smoke/test_outofbandmanagement.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 77 look OK, 8 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_role_lifecycle_clone | `Failure` | 0.88 | test_dynamicroles.py
   test_02_update_account | `Error` | 0.47 | test_accounts.py
   test_01_deploy_vm_with_extraconfig_throws_exception_kvm | `Error` | 0.16 | test_deploy_vm_extra_config_data.py
   test_02_deploy_vm_with_extraconfig_kvm | `Error` | 72.51 | test_deploy_vm_extra_config_data.py
   test_03_update_vm_with_extraconfig_kvm | `Error` | 144.37 | test_deploy_vm_extra_config_data.py
   test_17_retrieve_cpvm_default_files | `Error` | 130.03 | test_diagnostics.py
   test_18_retrieve_cpvm_single_file | `Error` | 134.01 | test_diagnostics.py
   test_01_add_delete_kubernetes_supported_version | `Error` | 1807.67 | test_kubernetes_supported_versions.py
   test_oobm_issue_power_off | `Error` | 18.31 | test_outofbandmanagement.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 391.36 | test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 353.45 | test_vpc_redundant.py
   test_hostha_kvm_host_fencing | `Error` | 183.75 | test_hostha_kvm.py
   test_hostha_kvm_host_recovering | `Error` | 735.02 | test_hostha_kvm.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4311: Trimming string api parameters and disallowing only space as an api parameter value

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4311:
URL: https://github.com/apache/cloudstack/pull/4311#issuecomment-693235031


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4311: Trimming string api parameters and disallowing only space as an api parameter value

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4311:
URL: https://github.com/apache/cloudstack/pull/4311#issuecomment-691660189


   Packaging result: ✖centos7 ✖centos8 ✖debian. JID-1987


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] davidjumani closed pull request #4311: Trimming string api parameters and disallowing only space as an api parameter value

Posted by GitBox <gi...@apache.org>.
davidjumani closed pull request #4311:
URL: https://github.com/apache/cloudstack/pull/4311


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] davidjumani commented on pull request #4311: Trimming string api parameters and disallowing only space as an api parameter value

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4311:
URL: https://github.com/apache/cloudstack/pull/4311#issuecomment-694812248


   Closing since this might break existing functionality and scenarios where there might be existing names, etc with leading / trailing spaces


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4311: Trimming string api parameters and disallowing only space as an api parameter value

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4311:
URL: https://github.com/apache/cloudstack/pull/4311#issuecomment-689472414


   @rhtyd a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware67, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4311: Trimming string api parameters and disallowing only space as an api parameter value

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4311:
URL: https://github.com/apache/cloudstack/pull/4311#issuecomment-692587154


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4311: Trimming string api parameters and disallowing only space as an api parameter value

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4311:
URL: https://github.com/apache/cloudstack/pull/4311#issuecomment-689305488


   Packaging result: ✔centos7 ✔centos8 ✔debian. JID-1923


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4311: Trimming string api parameters and disallowing only space as an api parameter value

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4311:
URL: https://github.com/apache/cloudstack/pull/4311#issuecomment-691410408


   <b>Trillian test result (tid-2719)</b>
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 72901 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4311-t2719-vmware-67u3.zip
   Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
   Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_extra_config_data.py
   Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py
   Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
   Intermittent failure detected: /marvin/tests/smoke/test_dynamicroles.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 76 look OK, 5 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_role_lifecycle_clone | `Failure` | 0.48 | test_dynamicroles.py
   test_02_update_account | `Error` | 0.43 | test_accounts.py
   test_04_deploy_vm_with_extraconfig_throws_exception_vmware | `Error` | 0.11 | test_deploy_vm_extra_config_data.py
   test_05_deploy_vm_with_extraconfig_vmware | `Error` | 139.18 | test_deploy_vm_extra_config_data.py
   test_00_deploy_vm_root_resize | `Failure` | 519.64 | test_deploy_vm_root_resize.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 558.89 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Error` | 3832.24 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Error` | 3832.28 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 0.03 | test_vpc_redundant.py
   ContextSuite context=TestVPCRedundancy>:teardown | `Error` | 0.05 | test_vpc_redundant.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4311: Trimming string api parameters and disallowing only space as an api parameter value

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4311:
URL: https://github.com/apache/cloudstack/pull/4311#issuecomment-692537992


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4311: Trimming string api parameters and disallowing only space as an api parameter value

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4311:
URL: https://github.com/apache/cloudstack/pull/4311#issuecomment-693720672


   <b>Trillian test result (tid-2755)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 54520 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4311-t2755-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
   Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_extra_config_data.py
   Intermittent failure detected: /marvin/tests/smoke/test_dynamicroles.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_outofbandmanagement.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 78 look OK, 7 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_role_lifecycle_clone | `Failure` | 2.08 | test_dynamicroles.py
   test_02_update_account | `Error` | 1.24 | test_accounts.py
   test_01_deploy_vm_with_extraconfig_throws_exception_kvm | `Error` | 0.92 | test_deploy_vm_extra_config_data.py
   test_02_deploy_vm_with_extraconfig_kvm | `Error` | 65.43 | test_deploy_vm_extra_config_data.py
   test_03_update_vm_with_extraconfig_kvm | `Error` | 160.90 | test_deploy_vm_extra_config_data.py
   test_01_deploy_kubernetes_cluster | `Error` | 0.29 | test_kubernetes_clusters.py
   test_02_deploy_kubernetes_ha_cluster | `Error` | 0.35 | test_kubernetes_clusters.py
   test_04_deploy_and_upgrade_kubernetes_cluster | `Error` | 0.34 | test_kubernetes_clusters.py
   test_05_deploy_and_upgrade_kubernetes_ha_cluster | `Error` | 0.23 | test_kubernetes_clusters.py
   test_06_deploy_and_invalid_upgrade_kubernetes_cluster | `Error` | 0.08 | test_kubernetes_clusters.py
   test_07_deploy_and_scale_kubernetes_cluster | `Error` | 0.09 | test_kubernetes_clusters.py
   test_oobm_issue_power_reset | `Error` | 10.99 | test_outofbandmanagement.py
   test_oobm_issue_power_status | `Error` | 21.38 | test_outofbandmanagement.py
   test_oobm_zchange_password | `Error` | 7.02 | test_outofbandmanagement.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 426.07 | test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Error` | 349.58 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Error` | 3866.97 | test_vpc_redundant.py
   test_hostha_kvm_host_fencing | `Error` | 167.14 | test_hostha_kvm.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4311: Trimming string api parameters and disallowing only space as an api parameter value

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4311:
URL: https://github.com/apache/cloudstack/pull/4311#issuecomment-691410408






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4311: Trimming string api parameters and disallowing only space as an api parameter value

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4311:
URL: https://github.com/apache/cloudstack/pull/4311#issuecomment-691655427


   @blueorangutan package
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] davidjumani commented on pull request #4311: Trimming string api parameters and disallowing only space as an api parameter value

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4311:
URL: https://github.com/apache/cloudstack/pull/4311#issuecomment-689294460


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org