You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@whimsical.apache.org by sebb <se...@gmail.com> on 2020/11/23 11:55:19 UTC
Re: [whimsy] branch master updated: add back in super, explicitly
passing in no block
Thanks for fixing that, I was about to try the same elimination
exercise using my branch.
The tests did not fail for me locally on macOS, which makes debugging harder.
On Mon, 23 Nov 2020 at 03:43, <ru...@apache.org> wrote:
>
> This is an automated email from the ASF dual-hosted git repository.
>
> rubys pushed a commit to branch master
> in repository https://gitbox.apache.org/repos/asf/whimsy.git
>
>
> The following commit(s) were added to refs/heads/master by this push:
> new 55cc6ca add back in super, explicitly passing in no block
> 55cc6ca is described below
>
> commit 55cc6cae9f60a907a301eefbe20134970e35f7a1
> Author: Sam Ruby <ru...@intertwingly.net>
> AuthorDate: Sun Nov 22 22:43:22 2020 -0500
>
> add back in super, explicitly passing in no block
> ---
> lib/whimsy/asf/ldap.rb | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/whimsy/asf/ldap.rb b/lib/whimsy/asf/ldap.rb
> index f25e41c..cac792a 100644
> --- a/lib/whimsy/asf/ldap.rb
> +++ b/lib/whimsy/asf/ldap.rb
> @@ -530,6 +530,7 @@ module ASF
> class LazyHash < Hash
> # capture an initializer to be called only if necessary.
> def initialize(&initializer)
> + super() {}
> @initializer = initializer
> end
>
>
Re: [whimsy] branch master updated: add back in super, explicitly
passing in no block
Posted by Sam Ruby <ru...@intertwingly.net>.
On Mon, Nov 23, 2020 at 6:55 AM sebb <se...@gmail.com> wrote:
>
> Thanks for fixing that, I was about to try the same elimination
> exercise using my branch.
>
> The tests did not fail for me locally on macOS, which makes debugging harder.
They also did not fail for me locally on macOS, Ubuntu (either pure or
WSL2). Or on whimsy-vm6. Very weird, given that they failed
consistently on Travis. That got me curious, and I used your branch
as a starting point.
The problem also wasn't obvious via inspection (hence why I also did
it via an elimination exercise), but once found made sense: Hash.new
will take a block parameter.
- Sam Ruby
> On Mon, 23 Nov 2020 at 03:43, <ru...@apache.org> wrote:
> >
> > This is an automated email from the ASF dual-hosted git repository.
> >
> > rubys pushed a commit to branch master
> > in repository https://gitbox.apache.org/repos/asf/whimsy.git
> >
> >
> > The following commit(s) were added to refs/heads/master by this push:
> > new 55cc6ca add back in super, explicitly passing in no block
> > 55cc6ca is described below
> >
> > commit 55cc6cae9f60a907a301eefbe20134970e35f7a1
> > Author: Sam Ruby <ru...@intertwingly.net>
> > AuthorDate: Sun Nov 22 22:43:22 2020 -0500
> >
> > add back in super, explicitly passing in no block
> > ---
> > lib/whimsy/asf/ldap.rb | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/lib/whimsy/asf/ldap.rb b/lib/whimsy/asf/ldap.rb
> > index f25e41c..cac792a 100644
> > --- a/lib/whimsy/asf/ldap.rb
> > +++ b/lib/whimsy/asf/ldap.rb
> > @@ -530,6 +530,7 @@ module ASF
> > class LazyHash < Hash
> > # capture an initializer to be called only if necessary.
> > def initialize(&initializer)
> > + super() {}
> > @initializer = initializer
> > end
> >
> >