You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/02/26 09:55:55 UTC

[GitHub] [rocketmq-client-cpp] ShannonDing opened a new pull request #261: feat(version): add api to get SDK versions

ShannonDing opened a new pull request #261: feat(version): add api to get SDK versions
URL: https://github.com/apache/rocketmq-client-cpp/pull/261
 
 
   ## What is the purpose of the change
   
   add api to get SDK versions
   CPP API: version()
   C API: ShowProducerVersion()... and so on.
   
   you can get SDK version strings like this:
   `SDK VERSION: V2.0.0, BUILD DATE: 02-14-2020, PROTOCOL VERSION: V4_6_0, LANGUAGE: CPP.`
   
   ## Brief changelog
   feat(version): add api to get SDK versions
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq-client-cpp] vongosling merged pull request #261: feat(version): add api to get SDK versions

Posted by GitBox <gi...@apache.org>.
vongosling merged pull request #261: feat(version): add api to get SDK versions
URL: https://github.com/apache/rocketmq-client-cpp/pull/261
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq-client-cpp] codecov-io commented on issue #261: feat(version): add api to get SDK versions

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #261: feat(version): add api to get SDK versions
URL: https://github.com/apache/rocketmq-client-cpp/pull/261#issuecomment-591360275
 
 
   # [Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/261?src=pr&el=h1) Report
   > Merging [#261](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/261?src=pr&el=desc) into [master](https://codecov.io/gh/apache/rocketmq-client-cpp/commit/9265ba4dd23c2c743d23f6a2d8354a5f7f037e1f?src=pr&el=desc) will **decrease** coverage by `<.01%`.
   > The diff coverage is `57.81%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/261/graphs/tree.svg?width=650&token=L5As3jdqFW&height=150&src=pr)](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/261?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #261      +/-   ##
   ==========================================
   - Coverage   57.86%   57.86%   -0.01%     
   ==========================================
     Files         182      182              
     Lines       11683    11747      +64     
   ==========================================
   + Hits         6760     6797      +37     
   - Misses       4923     4950      +27
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/261?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [src/protocol/ConsumerRunningInfo.h](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/261/diff?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL0NvbnN1bWVyUnVubmluZ0luZm8uaA==) | `100% <ø> (ø)` | :arrow_up: |
   | [src/producer/TransactionMQProducer.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/261/diff?src=pr&el=tree#diff-c3JjL3Byb2R1Y2VyL1RyYW5zYWN0aW9uTVFQcm9kdWNlci5jcHA=) | `0% <0%> (ø)` | :arrow_up: |
   | [src/MQClientFactory.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/261/diff?src=pr&el=tree#diff-c3JjL01RQ2xpZW50RmFjdG9yeS5jcHA=) | `18.67% <0%> (-0.03%)` | :arrow_down: |
   | [src/consumer/DefaultMQPullConsumer.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/261/diff?src=pr&el=tree#diff-c3JjL2NvbnN1bWVyL0RlZmF1bHRNUVB1bGxDb25zdW1lci5jcHA=) | `40.78% <100%> (+6%)` | :arrow_up: |
   | [src/common/DefaultMQClient.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/261/diff?src=pr&el=tree#diff-c3JjL2NvbW1vbi9EZWZhdWx0TVFDbGllbnQuY3Bw) | `71.02% <100%> (+0.83%)` | :arrow_up: |
   | [src/protocol/ConsumerRunningInfo.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/261/diff?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL0NvbnN1bWVyUnVubmluZ0luZm8uY3Bw) | `100% <100%> (ø)` | :arrow_up: |
   | [src/producer/DefaultMQProducer.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/261/diff?src=pr&el=tree#diff-c3JjL3Byb2R1Y2VyL0RlZmF1bHRNUVByb2R1Y2VyLmNwcA==) | `41.28% <100%> (+4.02%)` | :arrow_up: |
   | [test/src/protocol/ConsumerRunningInfoTest.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/261/diff?src=pr&el=tree#diff-dGVzdC9zcmMvcHJvdG9jb2wvQ29uc3VtZXJSdW5uaW5nSW5mb1Rlc3QuY3Bw) | `100% <100%> (ø)` | :arrow_up: |
   | [src/consumer/DefaultMQPushConsumer.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/261/diff?src=pr&el=tree#diff-c3JjL2NvbnN1bWVyL0RlZmF1bHRNUVB1c2hDb25zdW1lci5jcHA=) | `54.63% <100%> (+3.52%)` | :arrow_up: |
   | [src/extern/CPullConsumer.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/261/diff?src=pr&el=tree#diff-c3JjL2V4dGVybi9DUHVsbENvbnN1bWVyLmNwcA==) | `75.57% <33.33%> (-2.03%)` | :arrow_down: |
   | ... and [2 more](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/261/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/261?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/261?src=pr&el=footer). Last update [9265ba4...e15217d](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/261?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq-client-cpp] codecov-io edited a comment on issue #261: feat(version): add api to get SDK versions

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #261: feat(version): add api to get SDK versions
URL: https://github.com/apache/rocketmq-client-cpp/pull/261#issuecomment-591360275
 
 
   # [Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/261?src=pr&el=h1) Report
   > Merging [#261](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/261?src=pr&el=desc) into [master](https://codecov.io/gh/apache/rocketmq-client-cpp/commit/9265ba4dd23c2c743d23f6a2d8354a5f7f037e1f?src=pr&el=desc) will **increase** coverage by `0.55%`.
   > The diff coverage is `94.57%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/261/graphs/tree.svg?width=650&token=L5As3jdqFW&height=150&src=pr)](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/261?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #261      +/-   ##
   ==========================================
   + Coverage   57.86%   58.41%   +0.55%     
   ==========================================
     Files         182      182              
     Lines       11683    11769      +86     
   ==========================================
   + Hits         6760     6875     +115     
   + Misses       4923     4894      -29
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/261?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [src/protocol/ConsumerRunningInfo.h](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/261/diff?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL0NvbnN1bWVyUnVubmluZ0luZm8uaA==) | `100% <ø> (ø)` | :arrow_up: |
   | [src/consumer/DefaultMQPushConsumerImpl.h](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/261/diff?src=pr&el=tree#diff-c3JjL2NvbnN1bWVyL0RlZmF1bHRNUVB1c2hDb25zdW1lckltcGwuaA==) | `0% <ø> (ø)` | :arrow_up: |
   | [test/src/extern/CPushConsumerTest.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/261/diff?src=pr&el=tree#diff-dGVzdC9zcmMvZXh0ZXJuL0NQdXNoQ29uc3VtZXJUZXN0LmNwcA==) | `96.38% <100%> (+0.23%)` | :arrow_up: |
   | [test/src/MQClientAPIImpTest.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/261/diff?src=pr&el=tree#diff-dGVzdC9zcmMvTVFDbGllbnRBUElJbXBUZXN0LmNwcA==) | `94.73% <100%> (-0.72%)` | :arrow_down: |
   | [test/src/extern/CProducerTest.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/261/diff?src=pr&el=tree#diff-dGVzdC9zcmMvZXh0ZXJuL0NQcm9kdWNlclRlc3QuY3Bw) | `96.85% <100%> (+0.28%)` | :arrow_up: |
   | [test/src/extern/CPullConsumerTest.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/261/diff?src=pr&el=tree#diff-dGVzdC9zcmMvZXh0ZXJuL0NQdWxsQ29uc3VtZXJUZXN0LmNwcA==) | `100% <100%> (ø)` | :arrow_up: |
   | [src/common/DefaultMQClient.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/261/diff?src=pr&el=tree#diff-c3JjL2NvbW1vbi9EZWZhdWx0TVFDbGllbnQuY3Bw) | `71.02% <100%> (+0.83%)` | :arrow_up: |
   | [src/consumer/DefaultMQPullConsumer.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/261/diff?src=pr&el=tree#diff-c3JjL2NvbnN1bWVyL0RlZmF1bHRNUVB1bGxDb25zdW1lci5jcHA=) | `40.78% <100%> (+6%)` | :arrow_up: |
   | [src/producer/DefaultMQProducer.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/261/diff?src=pr&el=tree#diff-c3JjL3Byb2R1Y2VyL0RlZmF1bHRNUVByb2R1Y2VyLmNwcA==) | `41.28% <100%> (+4.02%)` | :arrow_up: |
   | [src/transport/TcpRemotingClient.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/261/diff?src=pr&el=tree#diff-c3JjL3RyYW5zcG9ydC9UY3BSZW1vdGluZ0NsaWVudC5jcHA=) | `9.26% <100%> (+0.51%)` | :arrow_up: |
   | ... and [16 more](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/261/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/261?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/261?src=pr&el=footer). Last update [9265ba4...8cc61f9](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/261?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq-client-cpp] vongosling commented on a change in pull request #261: feat(version): add api to get SDK versions

Posted by GitBox <gi...@apache.org>.
vongosling commented on a change in pull request #261: feat(version): add api to get SDK versions
URL: https://github.com/apache/rocketmq-client-cpp/pull/261#discussion_r384927004
 
 

 ##########
 File path: src/common/DefaultMQClient.cpp
 ##########
 @@ -24,11 +24,11 @@
 #include "UtilAll.h"
 
 namespace rocketmq {
-
+// hard code first.
 #define ROCKETMQCPP_VERSION "2.0.0"
-#define BUILD_DATE "02-14-2020"
+#define BUILD_DATE "22:50:18 02-14-2020"
 
 Review comment:
   ToDo, hope to be fixed in the near long time.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq-client-cpp] vongosling commented on a change in pull request #261: feat(version): add api to get SDK versions

Posted by GitBox <gi...@apache.org>.
vongosling commented on a change in pull request #261: feat(version): add api to get SDK versions
URL: https://github.com/apache/rocketmq-client-cpp/pull/261#discussion_r384500611
 
 

 ##########
 File path: include/CPushConsumer.h
 ##########
 @@ -36,6 +36,7 @@ ROCKETMQCLIENT_API CPushConsumer* CreatePushConsumer(const char* groupId);
 ROCKETMQCLIENT_API int DestroyPushConsumer(CPushConsumer* consumer);
 ROCKETMQCLIENT_API int StartPushConsumer(CPushConsumer* consumer);
 ROCKETMQCLIENT_API int ShutdownPushConsumer(CPushConsumer* consumer);
+ROCKETMQCLIENT_API const char* ShowPushConsumerVersion(CPushConsumer* consumer);
 
 Review comment:
   It would be better if we could get build info and core version from the property or using some other automatic style like maven build plugin, print it on startup and provide the runtime command for RocketMQ CLI framework.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq-client-cpp] vongosling commented on a change in pull request #261: feat(version): add api to get SDK versions

Posted by GitBox <gi...@apache.org>.
vongosling commented on a change in pull request #261: feat(version): add api to get SDK versions
URL: https://github.com/apache/rocketmq-client-cpp/pull/261#discussion_r384930734
 
 

 ##########
 File path: src/producer/DefaultMQProducerImpl.cpp
 ##########
 @@ -634,5 +636,15 @@ bool DefaultMQProducerImpl::dealWithNameSpace() {
   }
   return true;
 }
+void DefaultMQProducerImpl::logConfigs() {
+  showClientConfigs();
+
+  LOG_WARN("SendMsgTimeout:%d ms", m_sendMsgTimeout);
 
 Review comment:
   warn is not better for normal output.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services