You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cayenne.apache.org by aa...@apache.org on 2007/08/12 20:53:16 UTC

svn commit: r565116 - /cayenne/main/trunk/framework/cayenne-jdk1.4-unpublished/src/main/java/org/apache/cayenne/access/jdbc/EJBQLConditionTranslator.java

Author: aadamchik
Date: Sun Aug 12 11:53:15 2007
New Revision: 565116

URL: http://svn.apache.org/viewvc?view=rev&rev=565116
Log:
comment on correlated subqueries

Modified:
    cayenne/main/trunk/framework/cayenne-jdk1.4-unpublished/src/main/java/org/apache/cayenne/access/jdbc/EJBQLConditionTranslator.java

Modified: cayenne/main/trunk/framework/cayenne-jdk1.4-unpublished/src/main/java/org/apache/cayenne/access/jdbc/EJBQLConditionTranslator.java
URL: http://svn.apache.org/viewvc/cayenne/main/trunk/framework/cayenne-jdk1.4-unpublished/src/main/java/org/apache/cayenne/access/jdbc/EJBQLConditionTranslator.java?view=diff&rev=565116&r1=565115&r2=565116
==============================================================================
--- cayenne/main/trunk/framework/cayenne-jdk1.4-unpublished/src/main/java/org/apache/cayenne/access/jdbc/EJBQLConditionTranslator.java (original)
+++ cayenne/main/trunk/framework/cayenne-jdk1.4-unpublished/src/main/java/org/apache/cayenne/access/jdbc/EJBQLConditionTranslator.java Sun Aug 12 11:53:15 2007
@@ -120,6 +120,9 @@
 
         // run as a correlated subquery.
         // see "visitMemberOf" for correlated subquery logic
+        // also note that the code below is mostly copy/paste from MEMBER OF method ...
+        // maybe there's enough commonality in building correlated subqueries to make it
+        // reusable???
 
         if (expression.getChildrenCount() != 1) {
             throw new EJBQLException("SIZE must have exactly one child, got: "
@@ -133,7 +136,7 @@
         }
 
         EJBQLPath path = (EJBQLPath) expression.getChild(0);
-        
+
         String id = path.getAbsolutePath();
 
         String correlatedEntityId = path.getId();