[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on a change in pull request #225: [YUNIKORN-531] migrate to github action

[GitBox <gi...@apache.org>]

yangwwei commented on a change in pull request #225:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/225#discussion_r567602011



##########
File path: .travis.yml
##########
@@ -37,36 +37,11 @@ install: true
 
 jobs:
   include:
-    - stage: pre-commit checks
-      script:
-      - curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.33.0
-      - make license-check
-      - make test
-      - make lint
-      after_success: bash <(curl -s https://codecov.io/bash)
     - stage: publish docker image
       deploy:
         provider: script
         script: make push
         on:
           branch: master
           condition: $TRAVIS_EVENT_TYPE = cron

Review comment:
       I leave this as an open item for now, let the Travis job push the docker images until we figure out how to do that with github action. I think I've tried to do this github action before, but I met some token issue unsolved. That was a few months ago, we probably need to fix this in a second step.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org