[GitHub] [spark] HyukjinKwon commented on a change in pull request #31718: [SPARK-34225][CORE] Don't encode further when a URI form string is passed to addFile or addJar

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #31718:
URL: https://github.com/apache/spark/pull/31718#discussion_r586107086



##########
File path: core/src/main/scala/org/apache/spark/SparkContext.scala
##########
@@ -1975,9 +1976,9 @@ class SparkContext(config: SparkConf) extends Logging {
     } else {
       val (keys, scheme) = if (path.contains("\\") && Utils.isWindows) {
         // For local paths with backslashes on Windows, URI throws an exception
-        (addLocalJarFile(new File(path)), "local")
+        (addLocalJarFile(convertPathToFileForWin(path)), "local")

Review comment:
       @sarutak, I think here we assume the path is always a local path on Windows (not an URI) so I guess it's fine to leave it (?)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org