You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/11 14:33:19 UTC
[GitHub] [camel-website] shreyaag770 opened a new pull request #193: minor
CSS updated
shreyaag770 opened a new pull request #193: minor CSS updated
URL: https://github.com/apache/camel-website/pull/193
## Normal Resolution:
## Mobile Display (Before):
## Mobile Display(After):
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] shreyaag770 commented on issue #193: minor CSS
updated
Posted by GitBox <gi...@apache.org>.
shreyaag770 commented on issue #193: minor CSS updated
URL: https://github.com/apache/camel-website/pull/193#issuecomment-597782970
@zregvart I removed the text from previous/next links to make UI better. I also increased the arrow size to make it more easier for mobile user to navigate between next/previous page.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #193: minor CSS updated
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #193: minor CSS updated
URL: https://github.com/apache/camel-website/pull/193#issuecomment-598148294
@shreyaag770 yes, we try to make our pull request deal with a single topic, so please create a separate pull request for the swoosh change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] shreyaag770 commented on issue #193: minor CSS
updated
Posted by GitBox <gi...@apache.org>.
shreyaag770 commented on issue #193: minor CSS updated
URL: https://github.com/apache/camel-website/pull/193#issuecomment-598192829
Alright! @zregvart Thanku :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] shreyaag770 commented on issue #193: minor CSS
updated
Posted by GitBox <gi...@apache.org>.
shreyaag770 commented on issue #193: minor CSS updated
URL: https://github.com/apache/camel-website/pull/193#issuecomment-597679374
It will be really helpful if you could tell the reason for all the checks failed so that I won't repeat it again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #193: minor CSS updated
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #193: minor CSS updated
URL: https://github.com/apache/camel-website/pull/193#issuecomment-597769572
@shreyaag770 we sometimes have this intermittent failures with running the website build/checks, I've restarted the build so let's see if we get lucky on the second try.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] shreyaag770 commented on issue #193: minor CSS
updated
Posted by GitBox <gi...@apache.org>.
shreyaag770 commented on issue #193: minor CSS updated
URL: https://github.com/apache/camel-website/pull/193#issuecomment-597794677
There were few points I had in mind when I did this change -
- The way text was written was not presentable.
- If there are no text and only arrows in normal display then having text in mobile display was not appealing.
- To solve the user click problem I increased the arrow size, so it improves the UI as well as solve the the problem of mobile usability.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart closed pull request #193: minor CSS updated
Posted by GitBox <gi...@apache.org>.
zregvart closed pull request #193: minor CSS updated
URL: https://github.com/apache/camel-website/pull/193
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] shreyaag770 commented on issue #193: minor CSS
updated
Posted by GitBox <gi...@apache.org>.
shreyaag770 commented on issue #193: minor CSS updated
URL: https://github.com/apache/camel-website/pull/193#issuecomment-598212465
Should I send this PR again, 'minor CSS updated'?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #193: minor CSS updated
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #193: minor CSS updated
URL: https://github.com/apache/camel-website/pull/193#issuecomment-597777395
@shreyaag770 also, can you explain a bit about the motivations behind the changes you propose, it makes it easier for us to review. For example why remove the text from previous/next links?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #193: minor CSS updated
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #193: minor CSS updated
URL: https://github.com/apache/camel-website/pull/193#issuecomment-602563182
We haven't seen any new developments in 10 days so I think we can close this @shreyaag770 feel free to reopen when you have further changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] shreyaag770 removed a comment on issue #193: minor
CSS updated
Posted by GitBox <gi...@apache.org>.
shreyaag770 removed a comment on issue #193: minor CSS updated
URL: https://github.com/apache/camel-website/pull/193#issuecomment-598212465
Should I send this PR again, 'minor CSS updated'?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] shreyaag770 commented on issue #193: minor CSS
updated
Posted by GitBox <gi...@apache.org>.
shreyaag770 commented on issue #193: minor CSS updated
URL: https://github.com/apache/camel-website/pull/193#issuecomment-598101873
By mistake instead of sending another PR ,all the other commits have been applied to this PR. Should I send another PR and close this one?
The changes I want to make was:
I changed dark colors in Swoosh animation with lighter shades to increase the visibility of text.
Before:
After:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #193: minor CSS updated
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #193: minor CSS updated
URL: https://github.com/apache/camel-website/pull/193#issuecomment-597789637
@shreyaag770 can you explain specifically what makes the UI better when text is not present? I think having the text present makes for a larger touch target on mobile, so easier for the user to click on the link. Can you share your thoughts on this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #193: minor CSS updated
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #193: minor CSS updated
URL: https://github.com/apache/camel-website/pull/193#issuecomment-597789969
The preview is [here](https://builds.apache.org/job/Camel.website/job/PR-193/Preview/blog/LTS-Release-Schedule/).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services