You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/10/29 16:10:08 UTC
[GitHub] [beam] TheNeuralBit commented on a change in pull request #15811: [BEAM-12070] Make ParquetIO splittable by default
TheNeuralBit commented on a change in pull request #15811:
URL: https://github.com/apache/beam/pull/15811#discussion_r739369279
##########
File path: sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java
##########
@@ -387,11 +389,26 @@ public Read withBeamSchemas(boolean inferBeamSchema) {
return toBuilder().setInferBeamSchema(inferBeamSchema).build();
}
- /** Enable the Splittable reading. */
+ /**
+ * Enable the Splittable reading.
+ *
+ * @deprecated as of version 2.35.0. Splittable reading must be always enabled.
+ */
+ @Deprecated
public Read withSplit() {
return toBuilder().setSplittable(true).build();
}
+ /**
+ * Disable the Splittable reading.
+ *
+ * @deprecated as of version 2.35.0. Splittable reading must be always enabled.
Review comment:
nit:
```suggestion
* @deprecated This method may currently be used to opt-out of the default, splittable, behavior. However, this will be removed in a future release assuming no issues are discovered.
```
(potentially identify a specific release here?)
##########
File path: sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java
##########
@@ -387,11 +389,26 @@ public Read withBeamSchemas(boolean inferBeamSchema) {
return toBuilder().setInferBeamSchema(inferBeamSchema).build();
}
- /** Enable the Splittable reading. */
+ /**
+ * Enable the Splittable reading.
+ *
+ * @deprecated as of version 2.35.0. Splittable reading must be always enabled.
Review comment:
nit:
```suggestion
* @deprecated as of version 2.35.0. Splittable reading is enabled by default.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org