[GitHub] [spark] gatorsmile commented on a change in pull request #24336: [SPARK-27430][SQL] BroadcastNestedLoopJoinExec can build any side whatever the join type is

[GitBox <gi...@apache.org>]

gatorsmile commented on a change in pull request #24336: [SPARK-27430][SQL] BroadcastNestedLoopJoinExec can build any side whatever the join type is
URL: https://github.com/apache/spark/pull/24336#discussion_r274070011
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala
 ##########
 @@ -282,14 +282,16 @@ abstract class SparkStrategies extends QueryPlanner[SparkPlan] {
 
       // Pick BroadcastNestedLoopJoin if one side could be broadcast
       case j @ logical.Join(left, right, joinType, condition, hint)
-          if canBroadcastByHints(joinType, left, right, hint) =>
-        val buildSide = broadcastSideByHints(joinType, left, right, hint)
+          if hint.leftHint.exists(_.broadcast) || hint.rightHint.exists(_.broadcast) =>
+        val buildLeft = hint.leftHint.exists(_.broadcast)
+        val buildRight = hint.rightHint.exists(_.broadcast)
 
 Review comment:
   Our test cases do not cover the changes using these hints, right? Could you add them?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org