You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/13 08:53:36 UTC
[GitHub] [spark] zhengruifeng opened a new pull request #28202:
[SPARK-31433][ML] Summarizer supports string arguments
zhengruifeng opened a new pull request #28202: [SPARK-31433][ML] Summarizer supports string arguments
URL: https://github.com/apache/spark/pull/28202
### What changes were proposed in this pull request?
Summarizer supports string arguments
### Why are the changes needed?
It should be a little convenient if Summarizer supports string arguments, like other sql functions.
### Does this PR introduce any user-facing change?
yes, new methods added
### How was this patch tested?
existing testsuites
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28202:
[SPARK-31433][ML] Summarizer supports string arguments
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28202: [SPARK-31433][ML] Summarizer supports string arguments
URL: https://github.com/apache/spark/pull/28202#issuecomment-612816300
**[Test build #121191 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121191/testReport)** for PR 28202 at commit [`38bb4f9`](https://github.com/apache/spark/commit/38bb4f92a99a4b32916e3e1abb49295553d1b458).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28202: [SPARK-31433][ML]
Summarizer supports string arguments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28202: [SPARK-31433][ML] Summarizer supports string arguments
URL: https://github.com/apache/spark/pull/28202#issuecomment-612840772
**[Test build #121191 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121191/testReport)** for PR 28202 at commit [`38bb4f9`](https://github.com/apache/spark/commit/38bb4f92a99a4b32916e3e1abb49295553d1b458).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28202: [SPARK-31433][ML]
Summarizer supports string arguments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28202: [SPARK-31433][ML] Summarizer supports string arguments
URL: https://github.com/apache/spark/pull/28202#issuecomment-612816815
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on issue #28202: [SPARK-31433][ML]
Summarizer supports string arguments
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on issue #28202: [SPARK-31433][ML] Summarizer supports string arguments
URL: https://github.com/apache/spark/pull/28202#issuecomment-613325377
Oh, I fogot the python side.
I usually use `"foo"` instead of `$"foo"`, since most sql functions support both, for example in `functions.scala`:
```
/**
* Aggregate function: returns the maximum value of the column in a group.
*
* @group agg_funcs
* @since 1.3.0
*/
def max(columnName: String): Column = max(Column(columnName))
```
I tried to add this just for my perference, it maybe a little convenient, but I do not feel strongly about it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28202:
[SPARK-31433][ML] Summarizer supports string arguments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28202: [SPARK-31433][ML] Summarizer supports string arguments
URL: https://github.com/apache/spark/pull/28202#issuecomment-612841266
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121191/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on issue #28202: [SPARK-31433][ML]
Summarizer supports string arguments
Posted by GitBox <gi...@apache.org>.
srowen commented on issue #28202: [SPARK-31433][ML] Summarizer supports string arguments
URL: https://github.com/apache/spark/pull/28202#issuecomment-612926638
How about on the python side?
I am not against this; I have generally preferred one version of the API accepting Column as it's easy to express `$"foo"` vs just `"foo"` so I am not sure how to weigh the tiny upside vs tiny additional weight to the API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28202: [SPARK-31433][ML]
Summarizer supports string arguments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28202: [SPARK-31433][ML] Summarizer supports string arguments
URL: https://github.com/apache/spark/pull/28202#issuecomment-612816824
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25878/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28202:
[SPARK-31433][ML] Summarizer supports string arguments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28202: [SPARK-31433][ML] Summarizer supports string arguments
URL: https://github.com/apache/spark/pull/28202#issuecomment-612841263
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28202: [SPARK-31433][ML]
Summarizer supports string arguments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28202: [SPARK-31433][ML] Summarizer supports string arguments
URL: https://github.com/apache/spark/pull/28202#issuecomment-612841266
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121191/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28202:
[SPARK-31433][ML] Summarizer supports string arguments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28202: [SPARK-31433][ML] Summarizer supports string arguments
URL: https://github.com/apache/spark/pull/28202#issuecomment-612816824
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25878/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28202:
[SPARK-31433][ML] Summarizer supports string arguments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28202: [SPARK-31433][ML] Summarizer supports string arguments
URL: https://github.com/apache/spark/pull/28202#issuecomment-612816815
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28202: [SPARK-31433][ML]
Summarizer supports string arguments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28202: [SPARK-31433][ML] Summarizer supports string arguments
URL: https://github.com/apache/spark/pull/28202#issuecomment-612816300
**[Test build #121191 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121191/testReport)** for PR 28202 at commit [`38bb4f9`](https://github.com/apache/spark/commit/38bb4f92a99a4b32916e3e1abb49295553d1b458).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28202: [SPARK-31433][ML]
Summarizer supports string arguments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28202: [SPARK-31433][ML] Summarizer supports string arguments
URL: https://github.com/apache/spark/pull/28202#issuecomment-612841263
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org