You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "dkropachev (via GitHub)" <gi...@apache.org> on 2025/04/16 16:28:28 UTC
[PR] Add Makefile [cassandra-gocql-driver]
dkropachev opened a new pull request, #1881:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1881
Implement all CICD steps in Makefile and make workflows use Makefile.
It will help with local development and reproducing CICD issues locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Add Makefile [cassandra-gocql-driver]
Posted by "joao-r-reis (via GitHub)" <gi...@apache.org>.
joao-r-reis commented on PR #1881:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1881#issuecomment-2810252718
This seems like a reasonable proposal but I'd like to see some kind of discussion in a C* dev mailing list thread or ASF #cassandra-drivers slack channel to see if there is broad community support for this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSGO-76: Add Makefile [cassandra-gocql-driver]
Posted by "joao-r-reis (via GitHub)" <gi...@apache.org>.
joao-r-reis merged PR #1881:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Add Makefile [cassandra-gocql-driver]
Posted by "dkropachev (via GitHub)" <gi...@apache.org>.
dkropachev commented on PR #1881:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1881#issuecomment-2831877090
@joao-r-reis , can you please invite me to the slack, so that I could start discussion there ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Add Makefile [cassandra-gocql-driver]
Posted by "jameshartig (via GitHub)" <gi...@apache.org>.
jameshartig commented on code in PR #1881:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1881#discussion_r2072683679
##########
conn_test.go:
##########
Review Comment:
Are these changes necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSGO-76: Add Makefile [cassandra-gocql-driver]
Posted by "joao-r-reis (via GitHub)" <gi...@apache.org>.
joao-r-reis commented on code in PR #1881:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1881#discussion_r2114290431
##########
conn_test.go:
##########
Review Comment:
Oh that's a good catch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Add Makefile [cassandra-gocql-driver]
Posted by "dkropachev (via GitHub)" <gi...@apache.org>.
dkropachev commented on PR #1881:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1881#issuecomment-2844747581
> There's a [link on the repo's README file](https://github.com/apache/cassandra-gocql-driver/blob/trunk/README.md?plain=1#L4)
@joao-r-reis , that link is not working:
```
This invite has expired
We let the person who sent this invite know that you tried to join, so you may hear from them again soon.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Add Makefile [cassandra-gocql-driver]
Posted by "dkropachev (via GitHub)" <gi...@apache.org>.
dkropachev commented on PR #1881:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1881#issuecomment-2810168016
@tengu-alt, can you please review it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Add Makefile [cassandra-gocql-driver]
Posted by "joao-r-reis (via GitHub)" <gi...@apache.org>.
joao-r-reis commented on PR #1881:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1881#issuecomment-2847356833
I'm getting an error saying that a user with that email address is already on the slack workspace, you should be able to log in with that email address I think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Add Makefile [cassandra-gocql-driver]
Posted by "joao-r-reis (via GitHub)" <gi...@apache.org>.
joao-r-reis commented on PR #1881:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1881#issuecomment-2842257351
There's a [link on the repo's README file](https://github.com/apache/cassandra-gocql-driver/blob/trunk/README.md?plain=1#L4)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Add Makefile [cassandra-gocql-driver]
Posted by "joao-r-reis (via GitHub)" <gi...@apache.org>.
joao-r-reis commented on code in PR #1881:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1881#discussion_r2113657502
##########
conn_test.go:
##########
Review Comment:
Can you clarify? Are you saying this test isn't running in CICD on trunk atm?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Add Makefile [cassandra-gocql-driver]
Posted by "dkropachev (via GitHub)" <gi...@apache.org>.
dkropachev commented on code in PR #1881:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1881#discussion_r2073606880
##########
conn_test.go:
##########
Review Comment:
otherwise CICD would fail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSGO-76: Add Makefile [cassandra-gocql-driver]
Posted by "dkropachev (via GitHub)" <gi...@apache.org>.
dkropachev commented on code in PR #1881:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1881#discussion_r2114143634
##########
conn_test.go:
##########
Review Comment:
Sorry for missleading, in current cicd it is run without tags https://github.com/apache/cassandra-gocql-driver/blob/05e6036ff1d7d3d8aaacbe6817723e435cad22db/.github/workflows/main.yml#L25-L25
while in this PR it runs with all known tags:
```
go vet --tags "unit all cassandra integration" ./...
```
Since this file is tagged https://github.com/apache/cassandra-gocql-driver/blob/05e6036ff1d7d3d8aaacbe6817723e435cad22db/conn_test.go#L1-L2
It is not looked at by `go vet` in current CICD
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Add Makefile [cassandra-gocql-driver]
Posted by "dkropachev (via GitHub)" <gi...@apache.org>.
dkropachev commented on PR #1881:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1881#issuecomment-2847363217
> I'm getting an error saying that a user with that email address is already on the slack workspace, you should be able to log in with that email address I think?
Thanks someone already invited me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Add Makefile [cassandra-gocql-driver]
Posted by "dkropachev (via GitHub)" <gi...@apache.org>.
dkropachev commented on code in PR #1881:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1881#discussion_r2074989294
##########
conn_test.go:
##########
Review Comment:
There is no such step on CICD on trunk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Add Makefile [cassandra-gocql-driver]
Posted by "dkropachev (via GitHub)" <gi...@apache.org>.
dkropachev commented on PR #1881:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1881#issuecomment-2811767267
> This seems like a reasonable proposal but I'd like to see some kind of discussion in a C* dev mailing list thread or ASF `#cassandra-drivers` slack channel to see if there is broad community support for this
Can you invite me to the workspace and channel, you can find my email on the account.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Add Makefile [cassandra-gocql-driver]
Posted by "joao-r-reis (via GitHub)" <gi...@apache.org>.
joao-r-reis commented on code in PR #1881:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1881#discussion_r2073702864
##########
conn_test.go:
##########
Review Comment:
Why? CICD isn't failing currently on trunk, is it on a specific go version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Add Makefile [cassandra-gocql-driver]
Posted by "dkropachev (via GitHub)" <gi...@apache.org>.
dkropachev commented on code in PR #1881:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1881#discussion_r2114143634
##########
conn_test.go:
##########
Review Comment:
Sorry for missleading, in current cicd it is run without tags https://github.com/apache/cassandra-gocql-driver/blob/05e6036ff1d7d3d8aaacbe6817723e435cad22db/.github/workflows/main.yml#L25-L25
while in this PR it runs with all known tags:
```
go vet --tags "unit all cassandra integration" ./...
```
Since this file is tagged https://github.com/apache/cassandra-gocql-driver/blob/05e6036ff1d7d3d8aaacbe6817723e435cad22db/conn_test.go#L1-L2
It is not looked at up by `go vet` in current CICD
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org