You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by theomega <gi...@git.apache.org> on 2016/08/15 07:47:01 UTC

[GitHub] flink pull request #2373: [FLINK-4394] RMQSource: QueueName accessible for s...

GitHub user theomega opened a pull request:

    https://github.com/apache/flink/pull/2373

    [FLINK-4394] RMQSource: QueueName accessible for subclasses

    Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your changes.
    
    - [x] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [x] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [x] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed
    
    The queueName is needed if the subclasses override `setupQueue`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/theomega/flink patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2373.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2373
    
----
commit 04d6bf46e8d8684494522cd0c92ad462922d0af4
Author: Dominik <do...@dbruhn.de>
Date:   2016-08-15T07:41:57Z

    RMQSource: QueueName accessible for subclasses
    
    The queueName is needed if the subclasses override `setupQueue`.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2373: [FLINK-4394] RMQSource: QueueName accessible for subclass...

Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the issue:

    https://github.com/apache/flink/pull/2373
  
    I'm going to merge the change once travis gives green light.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2373: [FLINK-4394] RMQSource: QueueName accessible for subclass...

Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the issue:

    https://github.com/apache/flink/pull/2373
  
    Merging ...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #2373: [FLINK-4394] RMQSource: QueueName accessible for s...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/2373


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---