Re: [PR] fix: improve change detection for GHAs [superset]

["rusackas (via GitHub)" <gi...@apache.org>]

rusackas commented on code in PR #27904:
URL: https://github.com/apache/superset/pull/27904#discussion_r1552864303


##########
.github/workflows/codeql-analysis.yml:
##########
@@ -37,6 +33,12 @@ jobs:
       - name: Checkout repository
         uses: actions/checkout@v4
 
+      - name: Check for file changes
+        id: check
+        uses: ./.github/actions/change-detector/
+        with:
+          token: ${{ secrets.GITHUB_TOKEN }}

Review Comment:
   Is there a use case where you might use different github tokens for different actions? If not, you could DRY it up further and _not_ pass a token from every action to the change detector, but rather use the secret directly there. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org