You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Anshul Gangwar <an...@citrix.com> on 2014/04/14 10:42:07 UTC
Review Request 20313: CLOUDSTACK-6400:[hyper-v] [vmsync] Occasionally VM is
not deleted from back-end when it is stopped from Hyper-V manager and then
destroyed-expunged from CS
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20313/
-----------------------------------------------------------
Review request for cloudstack, Devdeep Singh and Rajesh Battala.
Bugs: CLOUDSTACK-6400
https://issues.apache.org/jira/browse/CLOUDSTACK-6400
Repository: cloudstack-git
Description
-------
CLOUDSTACK-6400: Occasionally VM is not deleted from back-end when it is stopped from Hyper-V manager and then destroyed-expunged from CS. With this patch hyper-v agent will delete the stopped VMs on hyper-v host so that hyper-v host is in consistent state with cloudstack. This patch will also make sure that VMs which are in process of creation they are returned as in PowerOn state so that they are not accidentally deleted. Notes are added to vm to identify whether it is created by cloudstack or not
Diffs
-----
plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResourceController.cs 4f4c14e
plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/IWmiCallsV2.cs 8c682ad
plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/WmiCallsV2.cs 79fd0bc
Diff: https://reviews.apache.org/r/20313/diff/
Testing
-------
verified
1. if vm is stopped from hyper-v manager then it should be automatically deleted
2. vms which is in process of creation is not getting accidentally deleted
3. proper notes are added to vm created by cloudstack
Thanks,
Anshul Gangwar
Re: Review Request 20313: CLOUDSTACK-6400:[hyper-v] [vmsync] Occasionally VM
is not deleted from back-end when it is stopped from Hyper-V manager and
then destroyed-expunged from CS
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20313/#review40358
-----------------------------------------------------------
Commit d45ee3ef21fd55c8a1cf1373225cab81389ad8c7 in cloudstack's branch refs/heads/4.4 from Anshul Gangwar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=d45ee3e ]
CLOUDSTACK-6400: [hyper-v] [vmsync] fixed occasionally VM is not deleted from back-end when it is stopped from Hyper-V manager and then destroyed-expunged from CS and returning only power VMs for vmsync
- ASF Subversion and Git Services
On April 14, 2014, 8:41 a.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20313/
> -----------------------------------------------------------
>
> (Updated April 14, 2014, 8:41 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh and Rajesh Battala.
>
>
> Bugs: CLOUDSTACK-6400
> https://issues.apache.org/jira/browse/CLOUDSTACK-6400
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-6400: Occasionally VM is not deleted from back-end when it is stopped from Hyper-V manager and then destroyed-expunged from CS. With this patch hyper-v agent will delete the stopped VMs on hyper-v host so that hyper-v host is in consistent state with cloudstack. This patch will also make sure that VMs which are in process of creation they are returned as in PowerOn state so that they are not accidentally deleted. Notes are added to vm to identify whether it is created by cloudstack or not
>
>
> Diffs
> -----
>
> plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResourceController.cs 4f4c14e
> plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/IWmiCallsV2.cs 8c682ad
> plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/WmiCallsV2.cs 79fd0bc
>
> Diff: https://reviews.apache.org/r/20313/diff/
>
>
> Testing
> -------
>
> verified
> 1. if vm is stopped from hyper-v manager then it should be automatically deleted
> 2. vms which is in process of creation is not getting accidentally deleted
> 3. proper notes are added to vm created by cloudstack
>
>
> Thanks,
>
> Anshul Gangwar
>
>
Re: Review Request 20313: CLOUDSTACK-6400:[hyper-v] [vmsync] Occasionally VM
is not deleted from back-end when it is stopped from Hyper-V manager and
then destroyed-expunged from CS
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20313/#review40368
-----------------------------------------------------------
Commit 3ec7497e1ebcaa65a8cbd24c27326356355ac8cc in cloudstack's branch refs/heads/master from Anshul Gangwar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=3ec7497 ]
CLOUDSTACK-6400: [hyper-v] [vmsync] fixed occasionally VM is not deleted from back-end when it is stopped from Hyper-V manager and then destroyed-expunged from CS and returning only power VMs for vmsync
- ASF Subversion and Git Services
On April 14, 2014, 8:41 a.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20313/
> -----------------------------------------------------------
>
> (Updated April 14, 2014, 8:41 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh and Rajesh Battala.
>
>
> Bugs: CLOUDSTACK-6400
> https://issues.apache.org/jira/browse/CLOUDSTACK-6400
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-6400: Occasionally VM is not deleted from back-end when it is stopped from Hyper-V manager and then destroyed-expunged from CS. With this patch hyper-v agent will delete the stopped VMs on hyper-v host so that hyper-v host is in consistent state with cloudstack. This patch will also make sure that VMs which are in process of creation they are returned as in PowerOn state so that they are not accidentally deleted. Notes are added to vm to identify whether it is created by cloudstack or not
>
>
> Diffs
> -----
>
> plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResourceController.cs 4f4c14e
> plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/IWmiCallsV2.cs 8c682ad
> plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/WmiCallsV2.cs 79fd0bc
>
> Diff: https://reviews.apache.org/r/20313/diff/
>
>
> Testing
> -------
>
> verified
> 1. if vm is stopped from hyper-v manager then it should be automatically deleted
> 2. vms which is in process of creation is not getting accidentally deleted
> 3. proper notes are added to vm created by cloudstack
>
>
> Thanks,
>
> Anshul Gangwar
>
>
Re: Review Request 20313: CLOUDSTACK-6400:[hyper-v] [vmsync] Occasionally VM
is not deleted from back-end when it is stopped from Hyper-V manager and
then destroyed-expunged from CS
Posted by Devdeep Singh <de...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20313/#review40371
-----------------------------------------------------------
Ship it!
Ship It!
- Devdeep Singh
On April 14, 2014, 8:41 a.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20313/
> -----------------------------------------------------------
>
> (Updated April 14, 2014, 8:41 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh and Rajesh Battala.
>
>
> Bugs: CLOUDSTACK-6400
> https://issues.apache.org/jira/browse/CLOUDSTACK-6400
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-6400: Occasionally VM is not deleted from back-end when it is stopped from Hyper-V manager and then destroyed-expunged from CS. With this patch hyper-v agent will delete the stopped VMs on hyper-v host so that hyper-v host is in consistent state with cloudstack. This patch will also make sure that VMs which are in process of creation they are returned as in PowerOn state so that they are not accidentally deleted. Notes are added to vm to identify whether it is created by cloudstack or not
>
>
> Diffs
> -----
>
> plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResourceController.cs 4f4c14e
> plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/IWmiCallsV2.cs 8c682ad
> plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/WmiCallsV2.cs 79fd0bc
>
> Diff: https://reviews.apache.org/r/20313/diff/
>
>
> Testing
> -------
>
> verified
> 1. if vm is stopped from hyper-v manager then it should be automatically deleted
> 2. vms which is in process of creation is not getting accidentally deleted
> 3. proper notes are added to vm created by cloudstack
>
>
> Thanks,
>
> Anshul Gangwar
>
>